Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use six.viewitems instead of six.iteritems to avoid encoding problems #2154

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

aynroot
Copy link
Contributor

@aynroot aynroot commented Oct 30, 2020

Should solve #2153


This change is Reviewable

@jeffwidman
Copy link
Contributor

jeffwidman commented Oct 31, 2020

I'm going to go ahead and merge so master is fixed, but @aynroot do you want to add a test for the underlying issue? IIRC, you had great test coverage originally, so I'm surprised this managed to slip through...

@aynroot
Copy link
Contributor Author

aynroot commented Nov 2, 2020

yes, I'll take care of it this week, wanted to unblock the issue as fast as possible last week without having much time

the problem I think is that the metadata method is the one currently which is not covered and is almost duplicated in the tests with a helper method :D

aynroot added a commit to aynroot/kafka-python that referenced this pull request Nov 4, 2020
Use six.viewitems instead of six.iteritems to avoid encoding problems (dpkp#2154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants