Friendlier message when cxx::CxxString
is used in a #[cxx::bridge]
.
#1414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One gotcha that sometimes trips new users of
cxx
is thatcxx::CxxString
works outside ofcxx::bridge
, but not within.This PR tries to improve this by providing a custom error message in this scenario.
Notes:
cxx::
a "qualifier" but it seems okay (FWIW paths containing::
are called "qualified paths" in Rust reference).cxx::
. Unfortunately, I wasn't able to figure out how to do it. It seems thatsyn::Error
doesn't support fix hints. And it seems that compiler folks say thatannotate_snippets
may be one option, but adopting this incxx
seems like a potentially bigger work item?cxx::CxxString
andCxxString
. I think that having a single spelling is somewhat more desirable (forgrep
ping, etc.), but I am open to implementing the alternative fix./cc @zetafunction, @adetaylor