Tidy up deprecations tab #1030
Merged
Tidy up deprecations tab #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deprecation-item as template-only component
- remove observer from deprecations controller
- vertical-collection in place of List table
- this, {{on}}, action, etc.
RobbieTheWagner
requested changes
Sep 18, 2019
| @@ -0,0 +1,71 @@ | |||
| $units: 0, 1, 2, 3, 4; | |||
There was a problem hiding this comment.
I would prefer to add tailwind, rather than maintaining our own custom utils. What would your thoughts be on that?
|
|
||
| filtered: computed('[email protected]', 'search', function() { | ||
| return this.model | ||
| .filter((item) => searchMatch(get(item, 'message'), this.search)); | ||
| }), | ||
|
|
||
| optionsChanged: observer('options.toggleDeprecationWorkflow', function() { |
There was a problem hiding this comment.
Always nice to see observers removed 😄
RobbieTheWagner
approved these changes
Sep 18, 2019
|
We can switch to tailwind later, going ahead and merging. |
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Ui::Accordion
* Utility CSS classes
* Cleanup Deprecations tab
- deprecation-item as template-only component
- remove observer from deprecations controller
- vertical-collection in place of List table
- this, {{on}}, action, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecation-itemas template-only componentvertical-collectionin place of List tablethis, {{on}}, action, <Component/>etc.With source maps:
Without source maps:
Old and busted: