Ensure renderDebug is properly unregistered. #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rwjblue
commented
May 12, 2020
| @@ -29,7 +29,7 @@ export default EmberObject.extend(PortMixin, { | |||
| }; | |||
|
|
|||
| this.profileManager.offProfilesAdded(this, this.sendAdded); | |||
| this.profileManager.offProfilesAdded(this, this._updateRenderPerformanceAndComponentTree); | |||
There was a problem hiding this comment.
This method doesn't exist on ember-debug/render-debug at all. It was removed in 4713877#diff-04f0316e4c3ec9f79f8bf1ec48f6aafbL45, but we missed updating the cleanup code with the renamed method.
Adds a side effecting import to `tests/test-helper.js` to ensure that `ember-debug/main` can be imported/required eagerly in the test suite (and is not broken by a cycle). Updates all lazy requires for `ember-debug` modules to ES module import statements.
rwjblue
force-pushed
the
ensure-cleanup-on-destruction
branch
from
e7ba7cb to
ec3b023
Compare
|
Looks good to me but is it possible to set up a CI scenario where we run the app test only, to avoid accidentally relying on ember debug existing? |
|
(ember-try tests are ember debug only, so they are like the opposite of that, and this new scenario can go into the same “phase”) |
RobbieTheWagner
approved these changes
May 12, 2020
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
Adds a side effecting import to `tests/test-helper.js` to ensure that `ember-debug/main` can be imported/required eagerly in the test suite (and is not broken by a cycle). Updates all lazy requires for `ember-debug` modules to ES module import statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a side effecting import to
tests/test-helper.jsto ensure thatember-debug/maincan be imported/required eagerly in the test suite (and is not broken by a cycle).Updates all lazy requires for
ember-debugmodules to ES module import statements.