Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop deprecation logging in console #347

Merged
merged 1 commit into from
Apr 19, 2015

Conversation

maheshsenni
Copy link
Contributor

No description provided.

@maheshsenni maheshsenni changed the title Stop deprecation logging in console #345 Stop deprecation logging in console Apr 17, 2015
@teddyzeenny
Copy link
Contributor

Thanks! Can you add a test to this file? Something like the (untested) code below:

//  Untested code
test("Warns once about deprecations", async function t(assert) {
  expect(2);
  let count = 0;
  port.get('adapter').reopen({
    debug(message) {
      assert.equal(message, 'Deprecations were detected, see the Ember Inspector deprecations tab for more details.');
      assert.equal(++count, 1, "Warns once");
    }
  });
  App.ApplicationRoute = Ember.Route.extend({
    setupController() {
      Ember.deprecate('Deprecation 1');
      Ember.deprecate('Deprecation 2');
    }
  });
  await visit('/');
});

@maheshsenni
Copy link
Contributor Author

@teddyzeenny test added. Thanks for being patient 😄

@teddyzeenny
Copy link
Contributor

Looks good. Can you squash your commits?

@maheshsenni maheshsenni force-pushed the deprecations-issue-345 branch from fea00af to ed07ded Compare April 19, 2015 12:27
@maheshsenni
Copy link
Contributor Author

Squashed them into a single commit 👍

teddyzeenny added a commit that referenced this pull request Apr 19, 2015
@teddyzeenny teddyzeenny merged commit dd495c0 into emberjs:master Apr 19, 2015
@teddyzeenny
Copy link
Contributor

Thanks!

@maheshsenni maheshsenni deleted the deprecations-issue-345 branch April 20, 2015 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants