Fix inspector reset on client app's reset and destroy #765
Conversation
| } else { | ||
| Adapter = instance.adapter; | ||
| } | ||
| register(instance, 'adapter:main', Adapter); |
There was a problem hiding this comment.
I know these manual registrations are not new, but I’m curious if we actually need them? I would think that putting a file at app/adapters/main.js (Or app/adapter.js) would “just work”?
There was a problem hiding this comment.
Good point. I think these should be turned into services, though it's probably not as simple as putting a file in the correct place since the adapter is registered as a different class depending on the environment (Chrome/FF/bookmarklet/tests).
There was a problem hiding this comment.
Are these adapters like normal adapters for ember-data in an application? If so, I would think they would be automatically registered.
There was a problem hiding this comment.
I'm going to merge the PR for now as we need this fix to release 3.0, we can look into refactoring this later.
| /** | ||
| * We use the application's id instead of the owner's id so that we use the same inspector | ||
| * instance for the same application even if it was reset (owner changes on reset). | ||
| * |
There was a problem hiding this comment.
Thank you for this write up, I was wondering why we needed it...
No description provided.