x-list -> list angle bracket component #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbishop16
previously requested changes
Jan 23, 2019
|
@rwjblue what should we do for supporting angle bracket components here? Should we drop the tests for anything pre 2.10? |
Also, converted some things to be angle bracket component syntax. This was just a proof of concept, to ensure things work before we do a larger refactor of the inspector.
RobbieTheWagner
force-pushed
the
list-refactor
branch
from
315e3da to
cea0aff
Compare
RobbieTheWagner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, converted some things to be angle bracket component syntax. This was just a proof of concept, to ensure things work before we do a larger refactor of the inspector.