-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appearence Enhancements #1111
base: main
Are you sure you want to change the base?
Appearence Enhancements #1111
Conversation
are you sure you're only adding a wallpaper selector? because im seeing a hella lot of other stuff, like japanese style workspace indicators and you commeneted out cheatsheet module |
when first used ur config i got keybinds error so i didnt bother to fix it just commented the line + i intended to make another pr for the unicode support for the workspaces where it support multiple languages natively not just 10 char currently supporting
|
Did you mean cheatsheet error? While I should admit that your work is cool and valuable, you should not just comment functional things (e.g. cheatsheet, music control) out, else we can not accept the PR, as we can not accept functional loss for insufficient reason. |
And yes, here's the problem. @Pharmaracist this PR has its content mismatching with the title. And you've already have another opened PR doing another lots of modifications... |
i forgot to uncomment that so i want to know first if you really need the hyprland_level transparency toggle or not so i can commit it |
i can close the other one for to be one pr at a time |
ill make another pr since the tweaks arent applied after changing the title idk that much about gh |
so for the musiccontrol it still works for me but the old py implementation thing idk what it was doing but we can use pywal separately for it since we really dont rely on it for everthing now but this will be at the cost of some interference with pywalfox since matugen patches it by masking |
so i made some very useful edits were now if you add / remove any images it auto generate /remove it and its thumbnail ill update the PR soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Partial review]
- This is just a gigantic block of changes that I don't yet fully understand and I'm not ready to merge yet
Files I haven't checked
.config/ags/scripts/color_generation/applycolor.sh
.config/ags/scripts/color_generation/colorgen.sh
.config/ags/scripts/color_generation/randomwall.sh
.config/ags/scripts/color_generation/switchcolor.sh
.config/ags/scripts/color_generation/switchwall.sh
.config/matugen/config.toml
.config/matugen/templates/ags.scss
.config/matugen/templates/colors.scss
.config/matugen/templates/colors.ini
.config/matugen/templates/foot.json
.config/matugen/templates/fuzzel.ini
.config/matugen/templates/gradience.json
.config/matugen/templates/gtk-colors.css
.config/matugen/templates/hyprland-colors.conf
.config/matugen/templates/hyprlock.conf
@@ -165,7 +181,11 @@ const WorkspaceContents = (count = 10) => { | |||
else | |||
cr.setSourceRGBA(inactivecolors.red, inactivecolors.green, inactivecolors.blue, inactivecolors.alpha); | |||
|
|||
layout.set_text(`${i + offset}`, -1); | |||
// Convert number to selected style | |||
const numberStyle = userOptions.workspaces.style || 'arabic'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arabic
@@ -0,0 +1,86 @@ | |||
{ | |||
"name": "Pharmaracism Theme", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind changing the name? i don't care about politics and stuff that might be called "politics"
wtf is politics now
i hate politics
ughhhh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you send a screenshot of how this looks like
.config/ags/switched_wallpapers.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file to be filled in by the wallpaper switcher? if so isn't it a better idea to store it in xdg state dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its not even needed we just use current_wallpaper.txt and colormode.txt where both are in the state dir this might be by accedent
- wallselect now uses rem instead of px - return cheatsheet - defaulting ws mode to "normal" - changing the leftover vibrant mode because its making matugen errors - add the rest of the color variables in the template
done ✅ |
@@ -35,7 +35,7 @@ | |||
|
|||
.generate-thumbnails { | |||
padding: 0.5rem 1rem; | |||
border-radius: 9999px; | |||
border-radius: 624.9375rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not this lmao
if its a circle just leave it as 9999px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made it w ai lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepseek aint playin mind games
hmm |
yes we can specify certain toml file for it |
the only conflicting thing here with the pywal is pywalfox we can disable this or redirect pywalfox for other output_path |
oh right |
ill also try to find a workaround without sacrificing pywalfox for the folks using firefox "using firefox w gtk is pure pain" |
so for the wallselect module it had some problems
Steps to Fix
|
huh |
SS :

Credits : @sh1zicus for the awesome Work with the wallselector