-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl:handshake/3 fails with cert_and_key_required and {handshake, hello}
specified
#9177
Comments
{handshake, hello}
specified {handshake, hello}
specified
You have a point, we will discuss it internally and come back to you. |
IngelaAndin
added a commit
to IngelaAndin/otp
that referenced
this issue
Jan 21, 2025
…used Also correct handshake enviroment handling so that {hanshake, hello} can be used in ssl:handshake aswell as in ssl:listen closes erlang#9177
IngelaAndin
added a commit
to IngelaAndin/otp
that referenced
this issue
Jan 21, 2025
…used Also correct handshake environment handling so that {hanshake, hello} can be used in ssl:handshake as well as in ssl:listen closes erlang#9177
IngelaAndin
added a commit
that referenced
this issue
Jan 22, 2025
* ingela/ssl/paused-hs/GH-9177/OTP-19445: ssl: Fix specs ssl: Postpone verifying of server options when {handshake, hello} is used
IngelaAndin
added a commit
that referenced
this issue
Jan 22, 2025
* ingela/ssl/paused-hs/GH-9177/OTP-19445: ssl: Fix specs ssl: Postpone verifying of server options when {handshake, hello} is used
IngelaAndin
added a commit
that referenced
this issue
Jan 24, 2025
This is a backpor of fix discribe as below in OTP-27 (option verification part missig in OTP-26) Postpone verifying of server options when {handshake, hello} is used Also correct handshake environment handling so that {hanshake, hello} can be used in ssl:handshake as well as in ssl:listen closes #9177
sverker
pushed a commit
that referenced
this issue
Feb 6, 2025
* ingela/ssl/paused-hs/GH-9177/OTP-19445: ssl: Fix specs ssl: Postpone verifying of server options when {handshake, hello} is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
With 7a07239
ssh:handshake/3
requires cert and key to be present.It must not require cert and key if
{handshake, hello}
is set because the actual cert and key to be used might be set later inssl:handshake_continue/3
based on information returned byssh:handshake/3
(e.g. the SNI hostname).To Reproduce
Expected behavior
Affected versions
OTP-27.2
OTP-27.1.3
OTP-27.1.2
OTP-27.1.1
OTP-27.1
OTP-27.0.1
OTP-27.0
OTP-27.0-rc3
OTP-27.0-rc2
OTP-27.0-rc1
Additional context
Workaround (bogus
cert
andkey
):The text was updated successfully, but these errors were encountered: