Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitenancy for the Client REST API for MAM and MUC-light #3147

Merged
merged 8 commits into from
Jun 9, 2021

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Jun 1, 2021

This PR addresses "Multitenancy for the Client REST API for MAM and MUC-light".

Proposed changes include:

  • rooms and messages endpoints

  • roster not included, because roster does not support MT yet.

  • We also log more in rest_helper in tests now (similar to the way we log stanzas).

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #3147 (2d15807) into master (647b6fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3147   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files         397      397           
  Lines       32322    32327    +5     
=======================================
+ Hits        25714    25719    +5     
  Misses       6608     6608           
Impacted Files Coverage Δ
...ngoose_client_api/mongoose_client_api_messages.erl 94.73% <100.00%> (+0.09%) ⬆️
.../mongoose_client_api/mongoose_client_api_rooms.erl 89.70% <100.00%> (+0.15%) ⬆️
src/muc_light/mod_muc_light_commands.erl 91.46% <100.00%> (+1.33%) ⬆️
src/muc_light/mod_muc_light_utils.erl 90.00% <100.00%> (+0.20%) ⬆️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 86.60% <0.00%> (-1.79%) ⬇️
src/wpool/mongoose_wpool.erl 84.00% <0.00%> (-1.00%) ⬇️
src/ejabberd_c2s.erl 88.99% <0.00%> (-0.30%) ⬇️
src/pubsub/mod_pubsub.erl 71.93% <0.00%> (+0.05%) ⬆️
src/mod_roster.erl 76.85% <0.00%> (+0.23%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647b6fb...2d15807. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I have a few comments.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit f8bb90b into master Jun 9, 2021
@chrzaszcz chrzaszcz deleted the mu-mt-rest branch June 9, 2021 13:58
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants