Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mod_inbox_backend from xref_ignores #3362

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Remove mod_inbox_backend from xref_ignores #3362

merged 1 commit into from
Oct 25, 2021

Conversation

vkatsuba
Copy link
Contributor

@vkatsuba vkatsuba requested a review from chrzaszcz October 25, 2021 12:19
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 25, 2021 •
edited
Loading

small_tests_24 / small_tests / e6c1563
Reports root / small

internal_mnesia_24 / internal_mnesia / e6c1563
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0

small_tests_23 / small_tests / e6c1563
Reports root / small

ldap_mnesia_24 / ldap_mnesia / e6c1563
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e6c1563
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

dynamic_domains_mysql_redis_24 / mysql_redis / e6c1563
Reports root/ big
OK: 2691 / Failed: 1 / User-skipped: 201 / Auto-skipped: 0

mam_SUITE:rdbms_simple_prefs_cases:messages_filtered_when_prefs_default_policy_is_never 
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e6c1563
Reports root/ big
OK: 2752 / Failed: 2 / User-skipped: 184 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"05c47984">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"ddef0404">>}]}]},
     "<message to='[email protected]' type='chat'><body>ddef0404</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1293}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1225}]}]}}

Report log

rest_client_SUITE:muc:messages_can_be_paginated_in_room 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"e0d60595">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"30887190">>}]}]},
     "<message to='[email protected]' type='chat'><body>30887190</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1293}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1225}]}]}}

Report log

dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / e6c1563
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

ldap_mnesia_23 / ldap_mnesia / e6c1563
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0

elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / e6c1563
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / e6c1563
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

mysql_redis_24 / mysql_redis / e6c1563
Reports root/ big
OK: 3069 / Failed: 3 / User-skipped: 228 / Auto-skipped: 0

mam_SUITE:rdbms_prefs_cases:prefs_set_cdata_request 
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected {prefs_result_iq,<<\"roster\">>,\n                  [<<\"[email protected]\">>,\n                   <<\"[email protected]\">>],\n                  []}\n\tValue {prefs_result_iq,<<\"always\">>,\n                 [<<\"[email protected]\">>,\n                <<\"[email protected]\">>],\n                 []}\n"}}

Report log

mam_SUITE:rdbms_simple_prefs_cases:messages_filtered_when_prefs_default_policy_is_never 
{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}

Report log

mod_event_pusher_rabbit_SUITE:group_chat_message_publish:group_chat_message_received_event_properly_formatted 
{error,
  {{assertMatch,
     [{module,mod_event_pusher_rabbit_SUITE},
      {line,435},
      {expression,
        "get_decoded_message_from_rabbit ( AliceGroupChatMsgRecvRK )"},
      {pattern,
        "# { << \"from_user_id\" >> := BobRoomJID , << \"to_user_id\" >> := AliceFullJID , << \"message\" >> := Message }"},
      {value,
        #{<<"from_user_id">> => <<"[email protected]">>,
        <<"message">> => <<>>,
        <<"to_user_id">> =>
          <<"alice_unnamed_86.221836@localhost/res1">>}}]},
   [{mod_event_pusher_rabbit_SUITE,
      '-group_chat_message_received_event_properly_formatted/1-fun-1-',3,
      [{file,
         "/home/circleci/app/big_tests/tests/mod_event_pusher_rabbit_SUITE.erl"},
       {line,435}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

mssql_mnesia_24 / odbc_mssql_mnesia / e6c1563
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0

pgsql_mnesia_23 / pgsql_mnesia / e6c1563
Reports root/ big
OK: 3096 / Failed: 1 / User-skipped: 211 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room 
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"bdfef0a2">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"ff5db3be">>}]}]},
     "<message to='[email protected]' type='chat'><body>ff5db3be</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1784}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1293}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1225}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / e6c1563
Reports root/ big
OK: 1715 / Failed: 1 / User-skipped: 326 / Auto-skipped: 0

offline_SUITE:mod_offline_tests:max_offline_messages_reached 
{error,
  {{assertion_failed,assert_many,false,
     [is_presence,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_SUITE.10.86803502>,
      #Fun<offline_SUITE.10.86803502>,#Fun<offline_S...

Report log

dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / e6c1563
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #3362 (e6c1563) into without-dynamic-backend-modules (09b14aa) will increase coverage by 0.02%.
The diff coverage is 97.22%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           without-dynamic-backend-modules    #3362      +/-   ##
===================================================================
+ Coverage                            80.81%   80.83%   +0.02%     
===================================================================
  Files                                  406      408       +2     
  Lines                                32608    32638      +30     
===================================================================
+ Hits                                 26353    26384      +31     
+ Misses                                6255     6254       -1
Impacted Files Coverage Δ
src/inbox/mod_inbox.erl 90.05% <ø> (-0.11%) ⬇️
src/inbox/mod_inbox_rdbms.erl 92.50% <ø> (ø)
src/inbox/mod_inbox_utils.erl 94.28% <ø> (ø)
src/smart_markers/mod_smart_markers.erl 91.89% <ø> (ø)
src/smart_markers/mod_smart_markers_rdbms.erl 92.30% <ø> (ø)
src/smart_markers/mod_smart_markers_backend.erl 91.66% <91.66%> (ø)
src/inbox/mod_inbox_backend.erl 100.00% <100.00%> (ø)
src/mod_roster_mnesia.erl 72.72% <0.00%> (-21.22%) ⬇️
src/ejabberd.erl 45.00% <0.00%> (-10.00%) ⬇️
src/elasticsearch/mongoose_elasticsearch.erl 76.92% <0.00%> (-7.70%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fcced8...e6c1563. Read the comment docs.

@arcusfelis arcusfelis merged commit 0533119 into without-dynamic-backend-modules Oct 25, 2021
@arcusfelis arcusfelis deleted the xref/remove_mod_inbox branch October 25, 2021 15:22
@Premwoik Premwoik modified the milestone: 5.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrzaszcz chrzaszcz Awaiting requested review from chrzaszcz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vkatsuba @mongoose-im @arcusfelis @Premwoik