Inbox - log errors when they happen #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #3366 +/- ##
==========================================
- Coverage 80.70% 80.67% -0.04%
==========================================
Files 397 397
Lines 32440 32438 -2
==========================================
- Hits 26182 26168 -14
- Misses 6258 6270 +12
Continue to review full report at Codecov.
|
NelsonVides
force-pushed
the
inbox/fixes
branch
from
6bb78af to
6d0ff73
Compare
This comment has been minimized.
This comment has been minimized.
|
small_tests_24 / small_tests / 730107f internal_mnesia_24 / internal_mnesia / 730107f small_tests_24 / small_tests / 730107f internal_mnesia_24 / internal_mnesia / 730107f small_tests_23 / small_tests / 730107f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 730107f service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>],
[<<"example1.com">>,<<"example2.com">>]}}}service_domain_db_SUITE:db:rest_with_auth:rest_delete_domain_cleans_data_from_mam{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_rest_delete_domain_cleans_data_from_mam_15.574626@example.org/res1">>,
escalus_tcp,<0.28734.1>,
[{event_manager,<0.28728.1>},
{server,<<"example.org">>},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_15.574626">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.28728.1>},
{server,<<"example.org">>},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_15.574626">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_15.574626">>},
{server,<<"example.org">>},
{host,<<"localhost">>},
{port,5232},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_15.574626">>},
{server,<<"example.org">>},
{host,<<"localhost">>},
{password,<<"makota3">>},
{port,5232},
{stream_id,<<"af666056c6e87fd4">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{service_domain_db_SUITE,
'-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5...service_domain_db_SUITE:db:rest_without_auth:rest_delete_domain_cleans_data_from_mam{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_rest_delete_domain_cleans_data_from_mam_23.724201@example.org/res1">>,
escalus_tcp,<0.29376.1>,
[{event_manager,<0.29370.1>},
{server,<<"example.org">>},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_23.724201">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.29370.1>},
{server,<<"example.org">>},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_23.724201">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_23.724201">>},
{server,<<"example.org">>},
{host,<<"localhost">>},
{port,5232},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"bob_rest_delete_domain_cleans_data_from_mam_23.724201">>},
{server,<<"example.org">>},
{host,<<"localhost">>},
{password,<<"makota3">>},
{port,5232},
{stream_id,<<"a598663a9eaeb185">>}]},
5000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{service_domain_db_SUITE,
'-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5...ldap_mnesia_24 / ldap_mnesia / 730107f jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_53.407868@localhost/res1">>},
{<<"id">>,<<"7db5c0d4-49e3-454c-8fbe-6898ac417588">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"7ddb8ea7-b755-4987-a717-40466ec35b6d">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_53.407868@localhost/res1' id='7db5c0d4-49e3-454c-8fbe-6898ac417588' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='7ddb8ea7-b755-4987-a717-40466ec35b6d'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,395}]},
{jingle_SUITE,
'-res...dynamic_domains_mysql_redis_24 / mysql_redis / 730107f ldap_mnesia_23 / ldap_mnesia / 730107f pgsql_mnesia_24 / pgsql_mnesia / 730107f dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 730107f dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 730107f service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}}service_mongoose_system_metrics_SUITE:xmpp_stanzas_counts_are_reported{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{escalus_client,start,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,58}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,131}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]}]}}sic_SUITE:mod_sic_tests:user_sic{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{escalus_client,start,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,58}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,131}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]}]}}sm_SUITE:parallel:server_enables_sm_after_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,server_enables_sm_after_session,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,246}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:server_returns_failed_after_auth{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,server_returns_failed,2,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,263}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:server_enables_sm_before_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,server_enables_sm_before_session,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,241}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:h_ok_before_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,h_ok_before_session,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,332}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:h_ok_after_session_enabled_before_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,h_ok_after_session_enabled_before_session,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,343}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:session_established{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,given_fresh_user_with_spec,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,1519}]},
{sm_SUITE,session_established,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,798}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]}]}}sm_SUITE:parallel:server_returns_failed_after_start{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,server_returns_failed,2,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,263}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:basic_ack{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,basic_ack,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,318}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:client_enables_sm_twice_fails_with_correct_error_stanza{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,client_enables_sm_twice_fails_with_correct_error_stanza,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,275}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:session_resumed_and_old_session_dead_doesnt_route_error_to_new_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,get_stream_resumption_enabled_fresh_user_smid_and_h,2,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,1368}]},
{sm_SUITE,session_resumed_and_old_session_dead_doesnt_route_error_to_new_session,
1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,304}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]}]}}sm_SUITE:parallel:server_enables_resumption{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,server_enables_resumption,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,258}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:session_resumed_then_old_session_is_closed_gracefully_with_correct_error_stanza{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,get_stream_resumption_enabled_fresh_user_smid_and_h,2,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,1368}]},
{sm_SUITE,session_resumed_then_old_session_is_closed_gracefully_with_correct_error_stanza,
1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,287}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]}]}}sm_SUITE:parallel:resume_session_kills_old_C2S_gracefully{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,resume_session_kills_old_C2S_gracefully,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,992}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:h_ok_after_a_chat{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{escalus_client,start,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,58}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,131}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]}]}}sm_SUITE:parallel:h_non_given_closes_stream_gracefully{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{escalus_client,start,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,58}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,131}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]}]}}sm_SUITE:parallel:wait_for_resumption{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,given_fresh_user_with_spec,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,1519}]},
{sm_SUITE,wait_for_resumption,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,809}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]}]}}sm_SUITE:parallel:resume_dead_session_results_in_item_not_found{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,session_resumption_expects_item_not_found,2,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,981}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:h_ok_after_session_enabled_after_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,h_ok_after_session_enabled_after_session,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,354}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:resend_unacked_on_reconnection{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,given_fresh_user_with_spec,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,1519}]},
{sm_SUITE,resend_unacked_on_reconnection,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,515}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]}]}}sm_SUITE:parallel:replies_are_processed_by_resumed_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,replies_are_processed_by_resumed_session,1,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,1122}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}sm_SUITE:parallel:resume_session{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{escalus_client,start,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,58}]},
{escalus_story,'-start_ready_clients/2-fun-0-',3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,131}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]}]}}sm_SUITE:parallel:resume_session_with_wrong_sid_returns_item_not_found{error,{"Expected stream features, got {xmlel,<<\"stream:error\">>,[],\n [{xmlel,<<\"host-unknown\">>,\n [{<<\"xmlns\">>,\n <<\"urn:ietf:params:xml:ns:xmpp-streams\">>}],\n []}]}",
[{escalus_session,assert_stream_features,3,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,291}]},
{escalus_session,stream_features,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,190}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1267}]},
{escalus_connection,start,2,
[{file,"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,144}]},
{sm_SUITE,session_resumption_expects_item_not_found,2,
[{file,"/home/circleci/app/big_tests/tests/sm_SUITE.erl"},
{line,981}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]}]}}215 errors were truncated elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 730107f mssql_mnesia_24 / odbc_mssql_mnesia / 730107f pgsql_mnesia_23 / pgsql_mnesia / 730107f mysql_redis_24 / mysql_redis / 730107f riak_mnesia_24 / riak_mnesia / 730107f |
arcusfelis
reviewed
Oct 27, 2021
src/inbox/mod_inbox.erl
Outdated
| end. | ||
|
|
||
| do_maybe_process_message(Acc, From, To, Msg, Dir) -> | ||
| %% In case of PgSQL we can we can update inbox and obtain unread_count in one query, |
Note that `mod_inbox_rdbms:set_inbox/6` does a strict match against `check_result` returning `ok`, but `_:set_inbox_incr_unread/5` does not have such strong verification.
These only make jumping to tags more annoying.
NelsonVides
force-pushed
the
inbox/fixes
branch
from
730107f to
47c46c2
Compare
|
small_tests_24 / small_tests / 47c46c2 internal_mnesia_24 / internal_mnesia / 47c46c2 small_tests_23 / small_tests / 47c46c2 ldap_mnesia_24 / ldap_mnesia / 47c46c2 dynamic_domains_mysql_redis_24 / mysql_redis / 47c46c2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 47c46c2 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 47c46c2 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 47c46c2 service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}}ldap_mnesia_23 / ldap_mnesia / 47c46c2 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 47c46c2 mysql_redis_24 / mysql_redis / 47c46c2 jingle_SUITE:all:jingle_session_is_established_when_calling_a_number{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"[email protected]">>},
{<<"to">>,
<<"alice_jingle_session_is_established_when_calling_a_number_5.116170@localhost/res1">>},
{<<"id">>,<<"9f6d4d4d-124d-4873-bf99-816e8ee272c6">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-info">>},
{<<"sid">>,<<"d78e4c91-a2c6-4ecd-98c3-4295db0b5415">>}],
[{xmlel,<<"ringing">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
[]}]}]},
"<iq from='[email protected]' to='alice_jingle_session_is_established_when_calling_a_number_5.116170@localhost/res1' id='9f6d4d4d-124d-4873-bf99-816e8ee272c6' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='d78e4c91-a2c6-4ecd-98c3-4295db0b5415'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,395}]},
{jingle_SUITE,
'-jingle_session_is_established_when_calling_a_number/1-fun-0-',1,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,...mam_SUITE:rdbms_cache_prefs_cases:messages_filtered_when_prefs_default_policy_is_roster{error,{test_case_failed,"ASSERT EQUAL\n\tExpected []\n\tValue [ok]\n"}}pgsql_mnesia_24 / pgsql_mnesia / 47c46c2 mssql_mnesia_24 / odbc_mssql_mnesia / 47c46c2 pgsql_mnesia_23 / pgsql_mnesia / 47c46c2 riak_mnesia_24 / riak_mnesia / 47c46c2 s2s_SUITE:both_tls_optional:simple_message{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_simple_message_62.814428@fed1/res1">>,
escalus_tcp,<0.12516.1>,
[{event_manager,<0.12512.1>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_62.814428">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.12512.1>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_62.814428">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_simple_message_62.814428">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alice_simple_message_62.814428">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{password,<<"makota2">>},
{stream_id,<<"6b051845a573c9f9">>}]},
10000],
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{s2s_SUITE,'-simple_message/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/s2s_SUITE.erl"},
{line,124}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_serve...dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 47c46c2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of code reorganisation that makes the review more complex, but in reality it all comes down to two points: first, defining specs and types more strictly for dialyzer, and second and more importantly, _not ignoring any error that
set_inbox_incr_unreadmight arise. At the very least, catch it in the message processor and log such error.Why so? All errors I've seen in CI are coming from the receiving user to get inconsistent results from his inbox. And turns out, if his values wouldn't be inserted, we wouldn't know at all.
There's just one type of error I've seen in inbox's CI, in
other_resources_do_not_interfere, where it all inserts just fine, but, the inbox query returns that there's four unread messages, instead of the expected two. That one I don't yet understand.