Move auth config spec to auth backend modules #3437
Conversation
chrzaszcz
force-pushed
the
auth-config-spec
branch
from
d0bbaec to
011412e
Compare
|
small_tests_23 / small_tests / d0bbaec small_tests_24 / small_tests / d0bbaec dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d0bbaec dynamic_domains_mysql_redis_24 / mysql_redis / d0bbaec dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d0bbaec ldap_mnesia_23 / ldap_mnesia / d0bbaec dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d0bbaec ldap_mnesia_24 / ldap_mnesia / d0bbaec internal_mnesia_24 / internal_mnesia / d0bbaec pgsql_mnesia_23 / pgsql_mnesia / d0bbaec elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d0bbaec pgsql_mnesia_24 / pgsql_mnesia / d0bbaec mssql_mnesia_24 / odbc_mssql_mnesia / d0bbaec mysql_redis_24 / mysql_redis / d0bbaec riak_mnesia_24 / riak_mnesia / d0bbaec |
Codecov Report
@@ Coverage Diff @@
## master #3437 +/- ##
==========================================
- Coverage 80.82% 80.80% -0.02%
==========================================
Files 414 415 +1
Lines 32312 32318 +6
==========================================
- Hits 26115 26114 -1
- Misses 6197 6204 +7
Continue to review full report at Codecov.
|
|
small_tests_24 / small_tests / 011412e small_tests_23 / small_tests / 011412e dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 011412e dynamic_domains_mysql_redis_24 / mysql_redis / 011412e dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 011412e dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 011412e ldap_mnesia_23 / ldap_mnesia / 011412e ldap_mnesia_24 / ldap_mnesia / 011412e internal_mnesia_24 / internal_mnesia / 011412e elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 011412e pgsql_mnesia_24 / pgsql_mnesia / 011412e pgsql_mnesia_23 / pgsql_mnesia / 011412e mssql_mnesia_24 / odbc_mssql_mnesia / 011412e mysql_redis_24 / mysql_redis / 011412e riak_mnesia_24 / riak_mnesia / 011412e |
chrzaszcz
force-pushed
the
auth-config-spec
branch
2 times, most recently
from
241e1be to
90f1ea5
Compare
|
small_tests_24 / small_tests / a5234d2 small_tests_23 / small_tests / a5234d2 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / a5234d2 dynamic_domains_mysql_redis_24 / mysql_redis / a5234d2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a5234d2 ldap_mnesia_23 / ldap_mnesia / a5234d2 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / a5234d2 ldap_mnesia_24 / ldap_mnesia / a5234d2 internal_mnesia_24 / internal_mnesia / a5234d2 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / a5234d2 pgsql_mnesia_23 / pgsql_mnesia / a5234d2 mysql_redis_24 / mysql_redis / a5234d2 pgsql_mnesia_24 / pgsql_mnesia / a5234d2 mssql_mnesia_24 / odbc_mssql_mnesia / a5234d2 riak_mnesia_24 / riak_mnesia / a5234d2 |
|
small_tests_24 / small_tests / 90f1ea5 small_tests_23 / small_tests / 90f1ea5 dynamic_domains_mysql_redis_24 / mysql_redis / 90f1ea5 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 90f1ea5 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 90f1ea5 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 90f1ea5 ldap_mnesia_24 / ldap_mnesia / 90f1ea5 ldap_mnesia_23 / ldap_mnesia / 90f1ea5 internal_mnesia_24 / internal_mnesia / 90f1ea5 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 90f1ea5 pgsql_mnesia_23 / pgsql_mnesia / 90f1ea5 mysql_redis_24 / mysql_redis / 90f1ea5 mssql_mnesia_24 / odbc_mssql_mnesia / 90f1ea5 pgsql_mnesia_24 / pgsql_mnesia / 90f1ea5 riak_mnesia_24 / riak_mnesia / 90f1ea5 |
chrzaszcz
force-pushed
the
auth-config-spec
branch
from
90f1ea5 to
f708bc7
Compare
chrzaszcz
force-pushed
the
auth-config-spec
branch
from
f708bc7 to
69640b1
Compare
This way it will be easier to introduce defaults and reuse code.
Currently it has mostly auth-related options, but the goal is to unify the common parts of LDAP configuration for auth, mod_shared_roster_ldap and mod_vcard.
chrzaszcz
force-pushed
the
auth-config-spec
branch
from
69640b1 to
dc96af3
Compare
|
small_tests_24 / small_tests / f708bc7 small_tests_23 / small_tests / f708bc7 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f708bc7 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / f708bc7 dynamic_domains_mysql_redis_24 / mysql_redis / f708bc7 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f708bc7 ldap_mnesia_23 / ldap_mnesia / f708bc7 ldap_mnesia_24 / ldap_mnesia / f708bc7 internal_mnesia_24 / internal_mnesia / f708bc7 pgsql_mnesia_23 / pgsql_mnesia / f708bc7 pgsql_mnesia_24 / pgsql_mnesia / f708bc7 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f708bc7 sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{thrown,{timeout,msg}}}mssql_mnesia_24 / odbc_mssql_mnesia / f708bc7 mysql_redis_24 / mysql_redis / f708bc7 riak_mnesia_24 / riak_mnesia / f708bc7 |
|
small_tests_24 / small_tests / 69640b1 small_tests_23 / small_tests / 69640b1 dynamic_domains_mysql_redis_24 / mysql_redis / 69640b1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 69640b1 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 69640b1 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 69640b1 ldap_mnesia_24 / ldap_mnesia / 69640b1 ldap_mnesia_23 / ldap_mnesia / 69640b1 internal_mnesia_24 / internal_mnesia / 69640b1 pgsql_mnesia_23 / pgsql_mnesia / 69640b1 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 69640b1 sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{thrown,{timeout,msg}}}pgsql_mnesia_24 / pgsql_mnesia / 69640b1 mysql_redis_24 / mysql_redis / 69640b1 mssql_mnesia_24 / odbc_mssql_mnesia / 69640b1 riak_mnesia_24 / riak_mnesia / 69640b1 sm_SUITE:parallel_manual_ack_freq_1:resume_session_state_stop_c2s{error,{thrown,{timeout,msg}}} |
|
small_tests_24 / small_tests / dc96af3 small_tests_23 / small_tests / dc96af3 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / dc96af3 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / dc96af3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / dc96af3 dynamic_domains_mysql_redis_24 / mysql_redis / dc96af3 ldap_mnesia_23 / ldap_mnesia / dc96af3 ldap_mnesia_24 / ldap_mnesia / dc96af3 internal_mnesia_24 / internal_mnesia / dc96af3 mysql_redis_24 / mysql_redis / dc96af3 pgsql_mnesia_24 / pgsql_mnesia / dc96af3 pgsql_mnesia_23 / pgsql_mnesia / dc96af3 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / dc96af3 mssql_mnesia_24 / odbc_mssql_mnesia / dc96af3 riak_mnesia_24 / riak_mnesia / dc96af3 |
| Items = maps:from_list([{a2b(Method), ejabberd_auth:config_spec(Method)} || | ||
| Method <- all_auth_methods()]), |
There was a problem hiding this comment.
This is the only part that feels like a hack, and still, it's so much cleaner than before. Have modules do their own configs, yay! 🎉
There was a problem hiding this comment.
Yes, I know it's not that clean, but it's the same as for modules and services.
Just like for modules and services, this keeps it more organized and simplifies future changes of auth handling, e.g. introducing defaults.