-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in mod_privacy #3876
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.13% // Head: 83.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3876 +/- ##
==========================================
- Coverage 83.13% 83.13% -0.01%
==========================================
Files 535 535
Lines 34199 34197 -2
==========================================
- Hits 28432 28428 -4
- Misses 5767 5769 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3036525
to
773749e
Compare
small_tests_24 / small_tests / 773749e small_tests_25 / small_tests / 773749e ldap_mnesia_24 / ldap_mnesia / 773749e dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 773749e dynamic_domains_mysql_redis_25 / mysql_redis / 773749e ldap_mnesia_25 / ldap_mnesia / 773749e dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 773749e dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 773749e pgsql_mnesia_24 / pgsql_mnesia / 773749e internal_mnesia_25 / internal_mnesia / 773749e elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 773749e mysql_redis_25 / mysql_redis / 773749e riak_mnesia_24 / riak_mnesia / 773749e pgsql_mnesia_25 / pgsql_mnesia / 773749e pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2826@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2826@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"dxfgfTXMwe62L1mNAbEMwg==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / 773749e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The types are a bit verbose but I guess it's better to be precise with hooks because of how they are executed.
This PR changes all hook handlers in
mod_privacy
module togen_hook
format.