-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing flaky test remove_dead_from_cluster_http #3968
Conversation
small_tests_24 / small_tests / 8332528 small_tests_25 / small_tests / 8332528 ldap_mnesia_24 / ldap_mnesia / 8332528 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8332528 ldap_mnesia_25 / ldap_mnesia / 8332528 dynamic_domains_mysql_redis_25 / mysql_redis / 8332528 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8332528 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8332528 pgsql_mnesia_24 / pgsql_mnesia / 8332528 internal_mnesia_25 / internal_mnesia / 8332528 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8332528 pgsql_mnesia_25 / pgsql_mnesia / 8332528 riak_mnesia_24 / riak_mnesia / 8332528 mssql_mnesia_25 / odbc_mssql_mnesia / 8332528 mysql_redis_25 / mysql_redis / 8332528 |
Codecov ReportBase: 83.54% // Head: 83.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3968 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 538 538
Lines 34003 34003
=======================================
+ Hits 28408 28409 +1
+ Misses 5595 5594 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixing flaky test remove_dead_from_cluster_http.
Removing join_unsuccessful_http test, because it was not testing anything(just receiving ok from GraphQL), and caused problems wit remove_dead_from_cluster_http.