Scram errors #4020
Scram errors #4020
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4020 +/- ##
==========================================
- Coverage 82.19% 82.18% -0.02%
==========================================
Files 535 535
Lines 33840 33841 +1
==========================================
- Hits 27816 27813 -3
- Misses 6024 6028 +4
☔ View full report in Codecov by Sentry. |
|
small_tests_24 / small_tests / 897d72b small_tests_25_arm64 / small_tests / 897d72b small_tests_25 / small_tests / 897d72b ldap_mnesia_24 / ldap_mnesia / 897d72b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 897d72b dynamic_domains_mysql_redis_25 / mysql_redis / 897d72b ldap_mnesia_25 / ldap_mnesia / 897d72b dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 897d72b internal_mnesia_25 / internal_mnesia / 897d72b elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 897d72b dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 897d72b pgsql_mnesia_24 / pgsql_mnesia / 897d72b mysql_redis_25 / mysql_redis / 897d72b jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_1556@localhost/res1">>},
{<<"id">>,<<"e7b8e048-6333-428f-bb4f-8a0664e98af3">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"a99fe07d-8ff7-4468-9edc-1dd15dd0cf58">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_1556@localhost/res1' id='e7b8e048-6333-428f-bb4f-8a0664e98af3' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='a99fe07d-8ff7-4468-9edc-1dd15dd0cf58'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
{line,389}]},
{jingle_SUITE,
'-resp_...pgsql_mnesia_25 / pgsql_mnesia / 897d72b mssql_mnesia_25 / odbc_mssql_mnesia / 897d72b |
This comment was marked as spam.
This comment was marked as spam.
The easiest way to test without having to reimplement nonces and salts in tests nor re-add fast_scram as a dependency to big-tests, was to blindly return 'not-authorised' to all error conditions. This nevertheless can be ok, as if we don't tell an attacker why the authentication failed, makes it harder for him to continue guessing.