-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctor/utils #4264
Doctor/utils #4264
Conversation
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 618d6db small_tests_25 / small_tests / 618d6db small_tests_26 / small_tests / 618d6db small_tests_26_arm64 / small_tests / 618d6db ldap_mnesia_25 / ldap_mnesia / 618d6db ldap_mnesia_26 / ldap_mnesia / 618d6db dynamic_domains_mysql_redis_26 / mysql_redis / 618d6db dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 618d6db dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 618d6db internal_mnesia_26 / internal_mnesia / 618d6db dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 618d6db pgsql_cets_26 / pgsql_cets / 618d6db mysql_redis_26 / mysql_redis / 618d6db pgsql_mnesia_25 / pgsql_mnesia / 618d6db pgsql_mnesia_26 / pgsql_mnesia / 618d6db mssql_mnesia_26 / odbc_mssql_mnesia / 618d6db |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4264 +/- ##
==========================================
+ Coverage 84.43% 84.44% +0.01%
==========================================
Files 552 553 +1
Lines 33554 33582 +28
==========================================
+ Hits 28330 28359 +29
+ Misses 5224 5223 -1 ☔ View full report in Codecov by Sentry. |
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / f1c5374 small_tests_25 / small_tests / f1c5374 small_tests_26_arm64 / small_tests / f1c5374 small_tests_26 / small_tests / f1c5374 ldap_mnesia_25 / ldap_mnesia / f1c5374 ldap_mnesia_26 / ldap_mnesia / f1c5374 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / f1c5374 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / f1c5374 dynamic_domains_mysql_redis_26 / mysql_redis / f1c5374 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / f1c5374 internal_mnesia_26 / internal_mnesia / f1c5374 pgsql_cets_26 / pgsql_cets / f1c5374 pgsql_mnesia_25 / pgsql_mnesia / f1c5374 pgsql_mnesia_26 / pgsql_mnesia / f1c5374 mysql_redis_26 / mysql_redis / f1c5374 mssql_mnesia_26 / odbc_mssql_mnesia / f1c5374 |
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 9be4cd5 small_tests_25 / small_tests / 9be4cd5 small_tests_26 / small_tests / 9be4cd5 small_tests_26_arm64 / small_tests / 9be4cd5 ldap_mnesia_26 / ldap_mnesia / 9be4cd5 ldap_mnesia_25 / ldap_mnesia / 9be4cd5 dynamic_domains_mysql_redis_26 / mysql_redis / 9be4cd5 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9be4cd5 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 9be4cd5 pgsql_cets_26 / pgsql_cets / 9be4cd5 internal_mnesia_26 / internal_mnesia / 9be4cd5 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 9be4cd5 pgsql_mnesia_26 / pgsql_mnesia / 9be4cd5 mysql_redis_26 / mysql_redis / 9be4cd5 pgsql_mnesia_25 / pgsql_mnesia / 9be4cd5 mssql_mnesia_26 / odbc_mssql_mnesia / 9be4cd5 sm_SUITE:ping_timeout{error,
{{assertion_failed,assert,is_presence,
{xmlel,<<"iq">>,
[{<<"from">>,<<"localhost">>},
{<<"to">>,
<<"alice_ping_timeout_3633@localhost/escalus-default-resource">>},
{<<"type">>,<<"get">>},
{<<"id">>,<<"5f3587c8d415f5b1">>}],
[{xmlel,<<"ping">>,[{<<"xmlns">>,<<"urn:xmpp:ping">>}],[]}]},
"<iq from='localhost' to='alice_ping_timeout_3633@localhost/escalus-default-resource' type='get' id='5f3587c8d415f5b1'><ping xmlns='urn:xmpp:ping'/></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_helper,initial_presence_step,2,
[{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
{line,135}]},
{escalus_connection,connection_step,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,163}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1599}]},
{escalus_connection,start,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,145}]},
{sm_helper,connect_spec,3,
[{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
{line,153}]},
{sm_SUITE,ping_timeout,1,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,625}]},
{test_server,ts_tc,3,[{file,"test_ser... |
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8946ed1 small_tests_25 / small_tests / 8946ed1 small_tests_26 / small_tests / 8946ed1 small_tests_26_arm64 / small_tests / 8946ed1 ldap_mnesia_25 / ldap_mnesia / 8946ed1 ldap_mnesia_26 / ldap_mnesia / 8946ed1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8946ed1 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8946ed1 dynamic_domains_mysql_redis_26 / mysql_redis / 8946ed1 internal_mnesia_26 / internal_mnesia / 8946ed1 pubsub_SUITE:tree+basic:publish_only_retract_items_scope_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-publish_only_retract_items_scope_test/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,645}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8946ed1 pgsql_cets_26 / pgsql_cets / 8946ed1 pgsql_mnesia_25 / pgsql_mnesia / 8946ed1 mysql_redis_26 / mysql_redis / 8946ed1 pgsql_mnesia_26 / pgsql_mnesia / 8946ed1 mssql_mnesia_26 / odbc_mssql_mnesia / 8946ed1 |
For now, the module contains utility functions for getting information about traced c2s hooks and exchanged XML elements.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 4a76216 small_tests_25 / small_tests / 4a76216 small_tests_26 / small_tests / 4a76216 small_tests_26_arm64 / small_tests / 4a76216 ldap_mnesia_25 / ldap_mnesia / 4a76216 graphql_server_SUITE:admin_cli:clustering_tests:remove_node_test{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,remove_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,225}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:stop_node_test{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,stop_node_test,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,230}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} service_mongoose_system_metrics_SUITE:log_transparency:just_removed_from_config_logs_question{error,
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,ensure_stopped,
[service_mongoose_system_metrics]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{service_mongoose_system_metrics_SUITE,disable_system_metrics,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,437}]},
{service_mongoose_system_metrics_SUITE,
just_removed_from_config_logs_question,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,283}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} service_domain_db_SUITE:init_per_suite{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost},
mongoose_service,loaded_services_with_opts,[]],
[{file,
"/home/circleci/project/big_tests/../test/common/distributed_helper.erl"},
{line,140}]},
{dynamic_services,save_services,2,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_services.erl"},
{line,15}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{service_domain_db_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,198}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1379}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 4a76216 ldap_mnesia_26 / ldap_mnesia / 4a76216 dynamic_domains_mysql_redis_26 / mysql_redis / 4a76216 pgsql_cets_26 / pgsql_cets / 4a76216 internal_mnesia_26 / internal_mnesia / 4a76216 pgsql_mnesia_25 / pgsql_mnesia / 4a76216 graphql_SUITE:tls_enabled:tls_connect_admin_unknown_certificate{error,{{assertMatch,[{module,graphql_SUITE},
{line,253},
{expression,"Result"},
{pattern,"{ error , { tls_alert , { unknown_ca , _ } } }"},
{value,{error,connection_closed}}]},
[{graphql_SUITE,tls_connect_admin_unknown_certificate,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_SUITE.erl"},
{line,253}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 4a76216 pgsql_mnesia_26 / pgsql_mnesia / 4a76216 mysql_redis_26 / mysql_redis / 4a76216 mssql_mnesia_26 / odbc_mssql_mnesia / 4a76216 ldap_mnesia_25 / ldap_mnesia / 4a76216 pgsql_mnesia_25 / pgsql_mnesia / 4a76216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍 I added a few minor comments
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 823959a small_tests_25 / small_tests / 823959a small_tests_26 / small_tests / 823959a small_tests_26_arm64 / small_tests / 823959a ldap_mnesia_25 / ldap_mnesia / 823959a dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 823959a dynamic_domains_mysql_redis_26 / mysql_redis / 823959a ldap_mnesia_26 / ldap_mnesia / 823959a dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 823959a dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 823959a internal_mnesia_26 / internal_mnesia / 823959a pgsql_cets_26 / pgsql_cets / 823959a pgsql_mnesia_25 / pgsql_mnesia / 823959a pgsql_mnesia_26 / pgsql_mnesia / 823959a mysql_redis_26 / mysql_redis / 823959a mssql_mnesia_26 / odbc_mssql_mnesia / 823959a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Add
tr_util
module with Erlang Doctor utilities.For now, the module contains utility functions for getting information
about traced c2s hooks and exchanged XML elements.