-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument mongoose_user_cache
#4323
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/instrument #4323 +/- ##
=======================================================
- Coverage 84.39% 35.35% -49.04%
=======================================================
Files 553 553
Lines 33874 33874
=======================================================
- Hits 28587 11976 -16611
- Misses 5287 21898 +16611 ☔ View full report in Codecov by Sentry. |
4a8dc96
to
5223783
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5223783
to
fd97605
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. I added a comment.
This comment was marked as outdated.
This comment was marked as outdated.
4c8a884
to
31c2b20
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 31c2b20 small_tests_25 / small_tests / 31c2b20 small_tests_26 / small_tests / 31c2b20 small_tests_26_arm64 / small_tests / 31c2b20 ldap_mnesia_25 / ldap_mnesia / 31c2b20 dynamic_domains_mysql_redis_26 / mysql_redis / 31c2b20 ldap_mnesia_26 / ldap_mnesia / 31c2b20 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 31c2b20 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 31c2b20 muc_SUITE:register:user_unregisters_nick_twice{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"4f30b0de900106a9577df3d7d3eca600">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-974af10c87">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"[email protected]/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"4f30b0de900106a9577df3d7d3eca600">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
... internal_mnesia_26 / internal_mnesia / 31c2b20 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 31c2b20 pgsql_mnesia_25 / pgsql_mnesia / 31c2b20 pgsql_cets_26 / pgsql_cets / 31c2b20 mysql_redis_26 / mysql_redis / 31c2b20 pgsql_mnesia_26 / pgsql_mnesia / 31c2b20 mssql_mnesia_26 / odbc_mssql_mnesia / 31c2b20 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 31c2b20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR updates the
mongoose_user_cache
metrics to usemongoose_instrument
. It removes old telemetry events and usesspan
to collect the needed information.Code changes
mongoose_user_cache
metrics to usemongoose_instrument
.span
to collect relevant information.Testing
muc_light_SUITE
tests, as this module uses them.