Docker args support #22
Conversation
| defp exec({"ARG", args}, context, _path) do | ||
| args = String.split(args, "=") | ||
|
|
||
| Map.merge(context, %{"Args" => Enum.at(args, 2)}) |
There was a problem hiding this comment.
Args attribute doesn't exist, doing a short search through google i didn't found anything related to this, so, don't even know if this is possible, did you test it?
There was a problem hiding this comment.
i found something https://docs.docker.com/engine/api/v1.37/#operation/ImageBuild, it has an attribute called buildargs which is only used when building the image, but not the container
There was a problem hiding this comment.
I didn't test using for real, only the test cover. I thought we had some args in the Bryan example.
There was a problem hiding this comment.
I haven’t been able to find anything about how to add support for ARG, I found about buildargs but is only supported when building a Dockerfile via build but we are not using it because we are building it manually (https://docs.docker.com/engine/api/v1.37/#operation/ImageBuild).
|
This has been open a long time - I can imagine it being useful - we do need to get the layer checksums / caching working though. I'd suggest we get that working first then look at merging this in. |
filipevarjao
force-pushed
the
docker_args_support
branch
from
2228ab0 to
1098b52
Compare
filipevarjao
force-pushed
the
docker_args_support
branch
from
1098b52 to
29ea7ce
Compare
No description provided.