github/workflows: remove coverage workflow #19424
Conversation
This workflow has already been migrated to the Prow infrastructure. Signed-off-by: Ivan Valdes <[email protected]>
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
github_actions
|
/test all |
|
/test pull-etcd-coverage-report |
1 similar comment
|
/test pull-etcd-coverage-report |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 31 files with indirect coverage changes @@ Coverage Diff @@
## main #19424 +/- ##
==========================================
- Coverage 68.95% 68.84% -0.12%
==========================================
Files 420 420
Lines 35753 35727 -26
==========================================
- Hits 24655 24595 -60
- Misses 9677 9703 +26
- Partials 1421 1429 +8 Continue to review full report in Codecov by Sentry.
|
ivanvc
force-pushed
the
remove-codecov-github-workflow
branch
from
1651346 to
5bb5f28
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivanvc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ivanvc
changed the title
Add extra arguments to ensure that CodeCov assumes the upload comes from a CI environment. Remove prerequisite from upload-coverage-report, to prepare to always upload the coverage report even if there's a test failure, restoring the original behavior. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
force-pushed
the
remove-codecov-github-workflow
branch
from
5bb5f28 to
7d87198
Compare
|
|
||
| set -o pipefail | ||
|
|
||
| # We try to upload whatever we have: | ||
| bash <(curl -s https://codecov.io/bash) -f ./covdir/all.coverprofile -cF all |
There was a problem hiding this comment.
FYI. I saw an error related to this script in another PR,
'cov' PASSED and completed at Sat Feb 22 17:08:13 UTC 2025
SUCCESS
./scripts/codecov_upload.sh
/dev/fd/63: line 2: syntax error near unexpected token `<'
/dev/fd/63: line 2: `<html><head>'
make: *** [Makefile:67: upload-coverage-report] Error 2
+ EXIT_VALUE=2
+ set +o xtrace
There was a problem hiding this comment.
It is highly likely that Codecov answered with an HTTP error. We could try to add retries or just run a /retest (or vendorize the script, which I don't think is a good idea). The previous behavior was not to do any retrying, but it should be easy to implement this. Let me know your thoughts.
There was a problem hiding this comment.
or vendorize the script,
I don't think it's a good idea either. We don't want to maintain/update it periodically.
The previous behavior was not to do any retrying, but it should be easy to implement this. Let me know your thoughts.
I think we should at least to avoid misleading error message. The error should be something like "failed to download the codecov script" instead of "syntax error near unexpected token `<'". Can we breakdown the one line script into multiple lines something like below,
curl -s https://codecov.io/bash -o codecov.sh
bash codecov.sh -f ./covdir/all.coverprofile -cF all
This workflow has already been migrated to the Prow infrastructure.
To have the Codecov bot publish the coverage report from the given pull request, it must be invoked using some additional arguments.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.