This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
Array fix with tests #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a bug when running RLP with some arrays.
|
LGTM but i can verify it test fails BEFORE fix since I can't run tests locally for some weird reason :( I will take a closer look later. Btw. @holgerd77 I think coveralls is computing code coverage wrong for ts projects :/ I mentioned it once. It's probably a problem of |
|
Btw. nice test @cag ;) |
|
@krzkaczor Ok, feel free to merge if you are satisfied. |
krzkaczor
approved these changes
Mar 1, 2019
|
@cag @InfiniteStyles thank you for your contribution! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@holgerd77 @krzkaczor Continuation of #68 and deals with #69