This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
Remove Dictionary type #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@holgerd77 pls release this PR |
|
Hi @pierreneter, sorry sorry sorry, was in a middle of a move. @alcuadrado didn't really follow this change here, a patch/bug fix release should do it I suppose? So |
|
I think this could be released as a patch version, as it's only a bug fix. TS users who were consuming this type may see their builds break, but there was no valid use of the type. Using it always leads to errors. What do you think, @s1na ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just removes the unused
Dictionarytype.As I said in #62, if an actual
Dictionaryis given toencode()it throws. This change only makes that case fail at compile-time.