Add timeout for all requests (closes #1)

Fix bug where requests.get would hang

pyreddit/config/config.py

@@ -1,3 +1,4 @@
 """Project-wide configuration variables."""
 MAX_POST_LENGTH = 500
 MAX_TITLE_LENGTH = 200
+REQUESTS_TIMEOUT = (2, 4)

pyreddit/helpers.py

@@ -205,6 +205,7 @@ def get_urls_from_text(text: str) -> List[str]:
                     word,
                     headers={"User-agent": os.getenv("REDDIT_USER_AGENT")},  # type: ignore
                     allow_redirects=False,
+                    timeout=config.REQUESTS_TIMEOUT,
                 )
                 start = resp.text.find("https://")
                 url = resp.text[start : resp.text.find('"', start)]

pyreddit/reddit.py

@@ -11,6 +11,7 @@
 
 import requests
 from dotenv import load_dotenv
+from .config import config
 
 from . import helpers
 from .exceptions import (
@@ -58,6 +59,7 @@ def _get_json(post_url: str) -> Any:
         response = requests.get(
             f"{post_url}.json",
             headers={"User-agent": os.getenv("REDDIT_USER_AGENT")},
+            timeout=config.REQUESTS_TIMEOUT,
         )
         json = response.json()
         # some subreddits have the json data wrapped in brackets, some do not

pyreddit/services/gfycat_service.py

@@ -11,6 +11,7 @@
 from ..models.content_type import ContentType
 from ..models.media import Media
 from .service import Service
+from ..config import config
 
 
 class Gfycat(Service):
@@ -46,7 +47,9 @@ def get(cls, url: str) -> Response:
         Makes a call to the provider's API.
         """
         return requests.get(
-            url, headers={"Authorization": f"Bearer {cls.access_token}"}
+            url,
+            headers={"Authorization": f"Bearer {cls.access_token}"},
+            timeout=config.REQUESTS_TIMEOUT,
         )
 
     @classmethod

pyreddit/services/service.py

@@ -1,7 +1,7 @@
 """Abstract Base static Class for every service."""
 from abc import abstractmethod
 from typing import Any, Optional, Union
-
+from ..config import config
 import requests
 from requests import Response
 
@@ -107,7 +107,7 @@ def get(cls, url: str) -> Union[Response, str]:
             Response from the service provider API.
 
         """
-        return requests.get(url, stream=True)
+        return requests.get(url, stream=True, timeout=config.REQUESTS_TIMEOUT)
 
     @classmethod
     @abstractmethod