RN: Revert setting hermesParser: true in default Metro config
#47670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66002056 |
…nfig (#47670) Summary: Now that we have `babel-plugin-syntax-hermes-parser` in `react-native/babel-preset` (since D63535216), it's no longer necessary to use `hermes-parser` directly in Metro in order to use newer Flow syntax. Babel with `babel-plugin-syntax-hermes-parser` is generally preferable, because it intelligently falls back to parsing with Babel for any non-`flow` files. See facebook/hermes#1549 for context. Changelog: [General][Fixed] metro-config: Don't use `hermes-parser` by default, prefer `babel-plugin-syntax-hermes-parser`, which supports other syntax plugins. Differential Revision: D66002056
facebook-github-bot
force-pushed
the
export-D66002056
branch
from
17433d6 to
ea80e4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66002056 |
|
This pull request has been merged in 398b3b3. |
|
This pull request was successfully merged by @robhogan in 398b3b3 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Dec 4, 2024
…nfig (#47670) Summary: Pull Request resolved: #47670 Now that we have `babel-plugin-syntax-hermes-parser` in `react-native/babel-preset` (since D63535216), it's no longer necessary to use `hermes-parser` directly in Metro in order to use newer Flow syntax. Babel with `babel-plugin-syntax-hermes-parser` is generally preferable, because it intelligently falls back to parsing with Babel for any non-`flow` files. See facebook/hermes#1549 for context. Changelog: [General][Fixed] metro-config: Don't use `hermes-parser` by default, prefer `babel-plugin-syntax-hermes-parser`, which supports other syntax plugins. Reviewed By: huntie Differential Revision: D66002056 fbshipit-source-id: cf48acec347e2c0791872f8ca4b53f5f8af1c783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that we have
babel-plugin-syntax-hermes-parserin@react-native/babel-preset(since D63535216), it's no longer necessary to usehermes-parserdirectly in Metro in order to use newer Flow syntax.Babel with
babel-plugin-syntax-hermes-parseris generally preferable, because it intelligently falls back to parsing with Babel for any non-@flowfiles.See facebook/hermes#1549 for context.
Changelog:
[General][Fixed] metro-config: Don't use
hermes-parserby default, preferbabel-plugin-syntax-hermes-parser, which supports other syntax plugins.Differential Revision: D66002056