Added type hints to 3-tier structural pattern #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faif
reviewed
Jun 23, 2020
faif
reviewed
Jun 23, 2020
faif
reviewed
Jun 25, 2020
|
|
||
|
|
||
| class Ui: | ||
| """ UI interaction class """ | ||
|
|
||
| def __init__(self): | ||
| def __init__(self) -> None: |
There was a problem hiding this comment.
My only objection is with the None returns. Can you give me examples of other projects that use it? I don't see an added value.
There was a problem hiding this comment.
I think its part of the convention here is the discussion that leads me to believe that
There was a problem hiding this comment.
Here's an example from Black formatter's source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.formatbased string formatting tof-stringbased formatting to avoidmypystring interpolation errormypyblackformatter with default config