Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audio CD support #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add audio CD support #25

wants to merge 3 commits into from

Conversation

hadess
Copy link
Collaborator

@hadess hadess commented Jan 5, 2020

WIP, not even compile tested.

@flathubbot
Copy link

Started test build 13388

@flathubbot
Copy link

Build 13388 failed

@hadess hadess force-pushed the wip/hadess/add-audio-cd branch from d3583d8 to 83be809 Compare January 5, 2020 23:55
@flathubbot
Copy link

Started test build 13389

@flathubbot
Copy link

Build 13389 failed

@hadess hadess force-pushed the wip/hadess/add-audio-cd branch from 83be809 to 0fd975b Compare January 6, 2020 08:57
@flathubbot
Copy link

Started test build 13399

TingPing
TingPing reviewed Jan 6, 2020
View reviewed changes
org.gnome.Rhythmbox3.json Outdated
"name": "gst-plugins-base",
"buildsystem": "meson",
"config-opts": [
"--prefix=/app",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"--prefix=/app",

?

TingPing
TingPing reviewed Jan 6, 2020
View reviewed changes
@flathubbot
Copy link

Build 13399 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12788/org.gnome.Rhythmbox3.flatpakref

@jmatthew
Copy link
Collaborator

jmatthew commented Jan 6, 2020

rhythmbox's cd lookup code doesn't actually use libmusicbrainz, so I think you can remove that and libneon.

@hadess
Copy link
Collaborator Author

hadess commented Jan 6, 2020

rhythmbox's cd lookup code doesn't actually use libmusicbrainz, so I think you can remove that and libneon.

libjuicer does, is that not used?

@jmatthew
Copy link
Collaborator

jmatthew commented Jan 6, 2020

rhythmbox's cd lookup code doesn't actually use libmusicbrainz, so I think you can remove that and libneon.

libjuicer does, is that not used?

not since 2012.

@flathubbot
Copy link

Started test build 13403

@hadess
Copy link
Collaborator Author

hadess commented Jan 6, 2020

not since 2012.

I'm old.

@flathubbot
Copy link

Build 13403 failed

@hadess hadess force-pushed the wip/hadess/add-audio-cd branch from 6cb3b93 to 3fa123c Compare January 6, 2020 10:04
@flathubbot
Copy link

Started test build 13405

@flathubbot
Copy link

Build 13405 failed

@hadess hadess force-pushed the wip/hadess/add-audio-cd branch from 3fa123c to 2508ba0 Compare January 6, 2020 10:25
@flathubbot
Copy link

Started test build 13408

@flathubbot
Copy link

Build 13408 failed

@hadess hadess force-pushed the wip/hadess/add-audio-cd branch from 2508ba0 to fbabc1f Compare January 6, 2020 10:52
@flathubbot
Copy link

Started test build 13409

@flathubbot
Copy link

Build 13409 failed

@hadess
Add audio CD playback and ripping support
e8f7eb6 
Add the cdparanoia gst plugin to support audio CD playback.

Closes: #11
@hadess hadess force-pushed the wip/hadess/add-audio-cd branch from fbabc1f to e8f7eb6 Compare January 6, 2020 11:17
@flathubbot
Copy link

Started test build 13415

@flathubbot
Copy link

Build 13415 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12804/org.gnome.Rhythmbox3.flatpakref

@hadess
Copy link
Collaborator Author

hadess commented Jan 6, 2020

Just waiting on a fix for this: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1689
(and testing)

@hadess hadess mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingPing TingPing TingPing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hadess @flathubbot @jmatthew @TingPing