fix(firefox): has selector freezes in certain situations #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
|
We might wait for a (short) while as mozilla is aware of that by https://bugzilla.mozilla.org/show_bug.cgi?id=1874066 |
|
I can confirm, the issue is fixed in latest firefox 123.a01 |
lubber-de
added
state/on-hold
|
Firefox 123 fixed the related issue, this PR is not needed anymore |
lubber-de
removed
the
state/on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firefox's implementation of the
:hasselector (perhaps in combination with the@supportsselector) makes firefox freeze in certain situations.After some investigation the reason are 3 of those selectors we implemented in 2.9.3.
As Firefox had officially enabled the
:hasfeature by default starting with FF 121 it was not happening before (and perhaps no FUI user was actively enabling it in older FF versions)As all other browsers work just fine this PR removed Firefox support for now until it's fixed by mozilla
I detected only the changed three
@supports selector(:has)selectors (in combination!) to trigger the freeze. In my tests, every other existing@supports selector(:has)selectors invented in 2.9.3 were not affected so i kept them untouched in this PRTestcase
Keep in mind that the selectors in question do not even belong to the example code! There is no piled segment and no pointing dropdown so the selector will not even trigger.
Broken
The tab freezes.
https://jsfiddle.net/e70xjovw/8/
Fixed
https://jsfiddle.net/e70xjovw/9/
Closes
#2971