Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(divider): vertical in stackable mobile grid #3170

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Feb 8, 2025

Description

Final fix for vertical divider inside a stackable grid. However, the divider needs to be set at the desired location (between the columns where it should be shown)

Testcase

Remove CSS to see issue while resizing the viewport to swtch between mobile view
https://jsfiddle.net/lubber/p8tfgbjq/12/

Closes

#531
Semantic-Org/Semantic-UI#4342
Semantic-Org/Semantic-UI#6637

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS tag/breaking-change Any pull request which is waiting for a breaking change release labels Feb 8, 2025
@lubber-de lubber-de added this to the 2.9.4 milestone Feb 8, 2025
@lubber-de lubber-de removed the tag/breaking-change Any pull request which is waiting for a breaking change release label Feb 8, 2025
@lubber-de lubber-de added the state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo label Feb 8, 2025
@lubber-de
Copy link
Member Author

docs added by fomantic/Fomantic-UI-Docs#531

@lubber-de lubber-de added the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 8, 2025
@lubber-de lubber-de merged commit f120df6 into fomantic:develop Feb 15, 2025
11 checks passed
@lubber-de lubber-de deleted the stackablegridDivider branch February 15, 2025 08:39
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Feb 15, 2025
divider inside stackable grids finally got a fix by fomantic/Fomantic-UI#3170
However, the divider needs to be placed between the columns where it should be shown.
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant