Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): resize ignored highlightrange setting #3177

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

lubber-de
Copy link
Member

Description

The new highlightRange option was visually ignored whenever the viewport triggered a resize and also the label were redrawn because of autoAdjust:true

Testcase

  • Watch the second example hghlightranges
  • resize the viewport so the labels will change
  • See the new labels are not highlighted within the selected range
  • Clicking on a thumb will re-highlight them again
    https://jsfiddle.net/lubber/1tvumckq/48/

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug javascript Pull requests that update Javascript code labels Feb 22, 2025
@lubber-de lubber-de added this to the 2.9.4 milestone Feb 22, 2025
@lubber-de lubber-de merged commit 08397dc into fomantic:develop Feb 23, 2025
11 checks passed
@lubber-de lubber-de deleted the fixSliderHightlightRange branch February 23, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant