Build doc using dotnet fsi 3.0.100 #31
Conversation
|
@sergey-tihon @dsyme I you want to have a look. |
|
The build is failing on travis because I also have to instal a 2.2 version of netcore |
|
This was due to paket.bootstrapper running as netcoreapp2.1 ... so netcore runtime 2.1 or 2.2 had to be installed to run paket. Now, everything is working as expected. |
|
@sergey-tihon @dsyme , I invited you to review since you can be interested to use it for other projects |
| // HACK: force usage of Fsharp.Compiler.Services | ||
| // or the indirect reference from FSharp.Literate will fail to load | ||
| let dummy (pos: FSharp.Compiler.Range.pos) = | ||
| pos.Column | ||
| FSharp.Compiler.Range.mkPos 1 1 |> dummy | ||
|
|
||
| // HACK: Force usage of Fable.Core | ||
| // or the indirect reference from Fable.React will fail to load | ||
| typeof<Fable.Core.EraseAttribute> | ||
|
|
There was a problem hiding this comment.
Just wow! It really works but looks sad...
I think that we should report this as dotnet fsi issue to dotnet/fsharp repo.
What do you think @thinkbeforecoding ?
There was a problem hiding this comment.
Yes, and I was even not ale to make the one for FSharp.Compiler work with a typeof<...> I don't really know why...
There was a problem hiding this comment.
I'm not aware of the issues around doc generation using dotnet fsi. Odd problem
There was a problem hiding this comment.
@dsyme FCS and Fable.Core are inderect references for FSharp.Literate and Fable.React. Just adding a #r to the assembly at the begining is not enough to make it work, dotnet fsi complains when loading FSharp.Literate or Fable.React that indirect dependencies cannot be found.
The hack is to actively use code from FCS and Fable.Core in dummy expression to force the assembly to load. Then the rest of the code works as expected.
There was a problem hiding this comment.
If this still doesn't work, can you point me to a repro and I will try to figure out what is needed.
Thanks
KEvin
|
@thinkbeforecoding should this be updated to the 3.1.201 SDK? |
This time, the documentation is run with
dotnet fsi generate.fsxfor real !