Validate microschema lists, Node update error handling #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ellipsis
This PR addresses some of the validation issues @xVinci6 talked about on Gitter last week. Specifically, it stops
DataService
from swallowing errors on product updates. Further, it adds active validation to microschema lists. So if there is a validation error in a microschema list, the invalid node can no longer be sent now, stopping the Bad Request errors from happening in the first place.Detailed issue description
DataService
(no return incatch
-> mapped to resolved promise withundefined
as parameter)undefined
as argument and fails badly, which is also why the buttons stay hidden.Solution
formIsValid()
method.Testing
There were no existing Integration Tests for this, so I did not add any new ones. I have verified that given issues are resolved locally.
If necessary for the workflow, I can split issues 1-3 into separate PRs and create issues.