Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /migrateSchemas endpoint #547

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Fix /migrateSchemas endpoint #547

merged 3 commits into from
Nov 21, 2018

Conversation

philippguertler
Copy link
Contributor

Fixes #532

Jotschi
Jotschi suggested changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@Jotschi Jotschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also apply the change in similar fashion to /migrateMicroschemas

@philippguertler philippguertler force-pushed the node-migration-race-condition branch from 288722e to 69c636b Compare November 16, 2018 15:45
@philippguertler
Copy link
Contributor Author

Change it for microschemas as well. Please review again.

@Jotschi
Copy link
Contributor

Jotschi commented Nov 20, 2018

LGTM - Run tests

@philippguertler philippguertler merged commit 28c0b1e into dev Nov 21, 2018
@philippguertler philippguertler deleted the node-migration-race-condition branch November 21, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jotschi Jotschi Jotschi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippguertler @Jotschi