Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point cloud shading options #9624

Closed
1 of 6 tasks
tdipisa opened this issue Oct 18, 2023 · 0 comments · Fixed by #9666, #9670 or #9722
Closed
1 of 6 tasks

Point cloud shading options #9624

tdipisa opened this issue Oct 18, 2023 · 0 comments · Fixed by #9666, #9670 or #9722
Assignees
@allyoucanmap @ElenaGallo
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C027-COMUNE_FI-2023-SUPPORT enhancement
Milestone
2023.02.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Oct 18, 2023

Description

To improve rendering and visualization effects of 3D Tiles point clouds, include support for shading options in MS.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@tdipisa tdipisa added enhancement 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Oct 18, 2023
@tdipisa tdipisa added this to the 2023.02.01 milestone Oct 18, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Oct 27, 2023
@allyoucanmap
geosolutions-it#9624 Point cloud shading options
9c0efdd
@allyoucanmap allyoucanmap mentioned this issue Oct 27, 2023
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request Oct 27, 2023 that will close this issue
#9624 Point cloud shading options #9666
Merged
5 tasks
offtherailz pushed a commit that referenced this issue Oct 27, 2023
@allyoucanmap
#9624 Point cloud shading options (#9666)
b94b6e3
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 27, 2023
@allyoucanmap allyoucanmap linked a pull request Oct 27, 2023 that will close this issue
Fix #9624 Include pointCloudShading option to saved layer config #9670
Merged
5 tasks
@ElenaGallo ElenaGallo self-assigned this Oct 27, 2023
@ElenaGallo ElenaGallo mentioned this issue Oct 27, 2023
Closed
2 tasks
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Nov 21, 2023
@allyoucanmap
Fix geosolutions-it#9624 Point cloud shading options (geosolutions-it…
cee6cf1 
…#9666)
@allyoucanmap allyoucanmap mentioned this issue Nov 21, 2023
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request Nov 21, 2023 that will close this issue
[Backport 2023.02.xx] Fix #9624 Point cloud shading options (#9666) #9722
Merged
5 tasks
MV88 added a commit that referenced this issue Nov 22, 2023
@MV88
Merge pull request #9722 from allyoucanmap/issue_9624_2023.02.xx
2ae9b16 
[Backport 2023.02.xx] Fix #9624 Point cloud shading options (#9666)
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 22, 2023
tdipisa pushed a commit that referenced this issue Nov 27, 2023
@MV88 @allyoucanmap
@diegovargasg @dsuren1 @mahmoudadel54
updating stable branch of genova (#9748)
e257122 
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <[email protected]>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Suren <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
Milestone
2023.02.01
3 participants
@tdipisa @allyoucanmap @ElenaGallo