Feat: invoice custom sections - discard service #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
force-pushed
the
feat-invoice-custom-sections-update-mutation
branch
from
b4e263a to
1001c58
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-discard-service
branch
from
d37e03f to
82cad0e
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-update-mutation
branch
from
c6613ea to
c53c9bf
Compare
Base automatically changed from
feat-invoice-custom-sections-update-mutation
to
main
December 13, 2024 14:31
annvelents
force-pushed
the
feat-invoice-custom-sections-discard-service
branch
from
9559082 to
7f7fa32
Compare
nudded
approved these changes
Dec 13, 2024
app/services/invoice_custom_sections/deselect/for_organization_service.rb
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A Service to destroy invoice custom sections
Description
As now we have another mechanism of deselecting invoice custom sections, it makes sense to extract deselect_for_all_usages service into their own service and extract the deselect services into their namespace