New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payment): Handling of amount_too_small - stripe webhooks #2985

Merged

vincent-pochet merged 2 commits into main from misc-payment-cleanup

Dec 19, 2024

Collaborator

vincent-pochet commented Dec 19, 2024

Description

This pull requests fixes two issues related to the recent refactoring of the payment handling on payment providers:

It makes sure that amount_too_small raised by stripe are correctly handled, by failing the Payment record and by setting the invoice.payment_status back to pending
I fixes some issues related to missing payment found/created on the fly when receiving Stripe webhooks for payment_intend


          misc(payment): Cleanup calls to payment jobs

85933c0

vincent-pochet changed the title ~~Misc payment cleanup~~ fix(payment): Handling of amount_too_small - stripe webhooks

rsempe approved these changes

View reviewed changes


          fix(payment): Handling of amount_too_small

cb16121

vincent-pochet force-pushed the misc-payment-cleanup branch from ed9e930 to cb16121 Compare

December 19, 2024 14:46

vincent-pochet merged commit 6b96df4 into main

6 checks passed

vincent-pochet deleted the misc-payment-cleanup branch

December 19, 2024 14:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet