misc(wallet): Refactor wallet transaction related jobs queuing #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-high-priority-top-up
branch
2 times, most recently
from
3505c6a to
fa7d50c
Compare
vincent-pochet
force-pushed
the
misc-high-priority-top-up
branch
from
fa7d50c to
5a649d7
Compare
brunomiguelpinto
approved these changes
Jan 9, 2025
annvelents
reviewed
Jan 9, 2025
annvelents
approved these changes
Jan 9, 2025
vincent-pochet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Queuing of wallet transaction related jobs is ideal as jobs as a low priority, meaning that under heavy load, they are a huge delay might happen between enqueue and processing. Since it is user facing, we need to improve it.
Description
This PR:
high_priorityqueue that should be used for all jobs requiring an "immediate" processingInvoices::PrepaidCreditJobfrom thewalletto the newhigh_priorityqueueWalletTransactions::CreateJobfrom thewalletto the newhigh_priorityqueueWallets::RefreshOngoingBalanceJobinto the low priority queueNote no more jobs will relies on the
walletqueue, but this queue is kept fro now in the config to avoid issue with existing enqueued jobs.