chore: Use enum with positional arguments #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syntax was introduced in Rails 7. The previous syntax will be deprecated in 7.2 and removed in 8,0.
ancorcruz
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Let's get ready for Rails 7.2
Description
I was looking at Ancor's PR to upgrade to Rails 7.2 and I thought we could extracted the enum changes to a separate PR since the syntax is already available.
Rails 7.2 will show a warning if we keep using the previous syntax (with a hash) and 8.0 will remove it entirely.
https://blog.saeloun.com/2021/02/26/rails-introduces-new-syntax-for-enum/