Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for Multiple Date Formats in Manual Payments Service #3110

Merged
merged 4 commits into from
Jan 27, 2025
Merged

feat: Support for Multiple Date Formats in Manual Payments Service #3110

merged 4 commits into from
Jan 27, 2025

Conversation

brunomiguelpinto
Copy link
Contributor

@brunomiguelpinto brunomiguelpinto commented Jan 27, 2025 •
edited
Loading

Context

Currently, the ManualPayments::CreateService requires the paid_at parameter to be formatted (YYYY-MM-DDTHH:MM:SSZ). The goal is to support multiple formats

"paid_at": "2025-01-10"
"paid_at": "2024-01-20 12:35"
"paid_at": "2025-01-10T00:00:00Z"

all of these formats will be accepted

@brunomiguelpinto brunomiguelpinto self-assigned this Jan 27, 2025
@brunomiguelpinto brunomiguelpinto changed the title fix: rubocop feat: Support for Multiple Date Formats in Manual Payments Service Jan 27, 2025
@brunomiguelpinto brunomiguelpinto merged commit ecb29ed into main Jan 27, 2025
6 checks passed
@brunomiguelpinto brunomiguelpinto deleted the fix-maual-payments-paid-at branch January 27, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivannovosad ivannovosad ivannovosad approved these changes

Assignees

@brunomiguelpinto brunomiguelpinto

Labels
Payment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunomiguelpinto @ivannovosad