fix(current usage): fix current usage taxes #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
reviewed
Jan 28, 2025
lovrocolic
commented
Jan 29, 2025
nudded
approved these changes
Jan 29, 2025
3 tasks
julienbourdeau
added a commit
that referenced
this pull request
Feb 6, 2025
## Context When calling `GET /customers/:cust_id/current_usage?external_subscription_id=:sub_id` Lago computes the current usage ## Description The taxes are computed by a thrid party (Anrok through Nango). We originally implemented a cache to avoir http calls to third party but it comes with drawbacks. We recently [tried to improve this](#3115). After investigation we believe it's best to remove the cache. - [x] Remove Anrok cache - [x] Introduce new `item_key` to reconcile fees when they are not persisted - [x] Add new `apply_taxes` params to the API - If you get an error due to third party, you can call again without taxes - In case you only need pre-tax amounts (like for b2b), passing `apply_taxes: false` will be more performant - getlago/lago-openapi#332 --------- Co-authored-by: Miguel Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, when fetching taxes from Anrok we used
fee.item_id(add_on_id,billable_metric_id,subscription_id) as main identifier that helps us map received taxes with certain fee on Lago side.First version worked well for real invoices, but also for current usage where we don't have ID persisted on fee.
However, there was a case where multiple charges are related to the same billable_metric (especially when one fee amount is zero and another is positive) and we were not able to perform mapping correctly: #2842
However, one regression bug was produced with latest changes. Since
fee.idis nil for current usage, taxes are not applied correctly in some scenarios.This PR fixes described case