bug(GracePeriod) - Make grace period update async for increased reliability #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
force-pushed
the
refactor-grace-period-saving
branch
from
4c00a51 to
48afa5b
Compare
nudded
force-pushed
the
refactor-grace-period-saving
branch
from
1d45cfa to
f916582
Compare
vincent-pochet
approved these changes
Feb 10, 2025
julienbourdeau
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The grace period update service was not built to deal with many (>100k) draft invoices. This means that some issuing_dates could be set incorrectly if the request timed out. This PR moves the update to an asynchronous job.
For idempotency reasons it's important to store the applied_grace_period on the invoice, this way we can be certain that we're not running the job twice.