-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9] Move the Network group over to the tox gen script #3979
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Co-authored-by: Daniel Szoke <[email protected]>
@@ -29,7 +29,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
python-version: ["3.8","3.9","3.11","3.12","3.13"] | |||
python-version: ["3.9","3.12","3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be concerned that tests for 3.8 and 3.11 are gone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reply as in the other PRs -- we're shrinking the Latest group by taking stuff out of it. So this is ok. It's all moving into the Pinned group instead.
@@ -306,6 +297,18 @@ envlist = | |||
{py3.9,py3.12,py3.13}-strawberry-v0.259.0 | |||
|
|||
|
|||
# ~~~ Network ~~~ | |||
{py3.7,py3.8}-grpc-v1.32.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the .github/workflows
, we don't have either of these Python versions. Is that because the line changed in this PR is for the latest
tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you have to look at Python versions in the Pinned group instead, that's what gets generated by this script.
requests
,grpc
from the tox templatepopulate_tox.py
populate_tox.py
to fill in entries for themsplit_gh_tox_actions.py
to generate the CI yaml files so that they correspond to the new tox.iniThe remaining integrations in this group are not trivial to port to the script, I'll do this step by step in follow-up PRs.