Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing method to iOS noop-bridge #1983

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jan 21, 2025

Fixes #1982

The NoOp bridge was missing a method the bridge proxy was expecting.
To prevent any future regressions I've added a test that fetches all EntryPoints used in our bridge proxy. This should give a good snapshot/indication of what we're expecting to be in the bridge. We're comparing that list with what's in the bridges. One edgecase due to convention and therefor not covered is future additions to the bridge proxy that don't rely on EntryPoint.

@bitsandfoxes bitsandfoxes requested a review from vaind January 23, 2025 11:42
@bitsandfoxes bitsandfoxes merged commit 79491f6 into main Jan 23, 2025
55 of 57 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/ios-noop-bridge branch January 23, 2025 16:21
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Added missing method to iOS noop-bridge ([#1983](https://github.com/getsentry/sentry-unity/pull/1983))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against f87f031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Undefined symbol: _SentryNativeBridgeIsEnabled when Sentry is Disabled in Core Options
2 participants