Fix calling beforeSend handler during post-loading
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustanivsky
changed the title
beforeSend handler during post-loading
bitsandfoxes
reviewed
Jul 9, 2024
| USentryEvent* ProcessedEvent = EventToProcess; | ||
| if(!FUObjectThreadContext::Get().IsRoutingPostLoad) | ||
| { | ||
| // Executing UFUNCTION is allowed only when not post-loading |
There was a problem hiding this comment.
Could you provide some context what this means?
There was a problem hiding this comment.
Post-loading is a part of an actor lifecycle that goes right after finishing loading it from disk (i.e. when a game map opened in editor). Typically at this point some related actor's versioning or fixup behavior should be called. It's unsafe to use any blueprint-implemented functions (like HandleBeforeSend in our case) during this stage so we've added an extra check here to avoid triggering a corresponding assertion.
There was a problem hiding this comment.
Thanks for the explanation!
# Conflicts: # CHANGELOG.md # plugin-dev/Source/Sentry/Private/SentrySubsystem.cpp
bitsandfoxes
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #505 (comment)