feat: str_attr and num_attr materialized views for new eap_items table #6907
+352
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a migration; here is the generated SQL for -- start migrations
-- forward migration events_analytics_platform : 0029_items_attribute_table_v1
Local op: CREATE TABLE IF NOT EXISTS items_str_attrs_1_local (organization_id UInt64, project_id UInt64, item_type UInt8, attr_key String CODEC (ZSTD(1)), attr_value String CODEC (ZSTD(1)), timestamp DateTime CODEC (DoubleDelta, ZSTD(1)), retention_days UInt16, count SimpleAggregateFunction(sum, UInt64)) ENGINE ReplicatedAggregatingMergeTree('/clickhouse/tables/events_analytics_platform/{shard}/default/items_str_attrs_1_local', '{replica}') PRIMARY KEY (organization_id, attr_key) ORDER BY (organization_id, attr_key, item_type, attr_value, project_id, timestamp, retention_days) PARTITION BY (retention_days, toMonday(timestamp)) TTL timestamp + toIntervalDay(retention_days) SETTINGS index_granularity=8192;
Distributed op: CREATE TABLE IF NOT EXISTS items_str_attrs_1_dist (organization_id UInt64, project_id UInt64, item_type UInt8, attr_key String CODEC (ZSTD(1)), attr_value String CODEC (ZSTD(1)), timestamp DateTime CODEC (DoubleDelta, ZSTD(1)), retention_days UInt16, count SimpleAggregateFunction(sum, UInt64)) ENGINE Distributed(`cluster_one_sh`, default, items_str_attrs_1_local);
Local op: CREATE MATERIALIZED VIEW IF NOT EXISTS items_str_attrs_1_mv TO items_str_attrs_1_local (organization_id UInt64, project_id UInt64, item_type UInt8, attr_key String CODEC (ZSTD(1)), attr_value String CODEC (ZSTD(1)), timestamp DateTime CODEC (DoubleDelta, ZSTD(1)), retention_days UInt16, count SimpleAggregateFunction(sum, UInt64)) AS
SELECT
organization_id,
project_id,
item_type,
attrs.1 as attr_key,
attrs.2 as attr_value,
toStartOfDay(timestamp) AS timestamp,
retention_days,
1 AS count
FROM eap_items_1_local
LEFT ARRAY JOIN
arrayConcat(
CAST(attributes_string_0, 'Array(Tuple(String, String))'), CAST(attributes_string_1, 'Array(Tuple(String, String))'), CAST(attributes_string_2, 'Array(Tuple(String, String))'), CAST(attributes_string_3, 'Array(Tuple(String, String))'), CAST(attributes_string_4, 'Array(Tuple(String, String))'), CAST(attributes_string_5, 'Array(Tuple(String, String))'), CAST(attributes_string_6, 'Array(Tuple(String, String))'), CAST(attributes_string_7, 'Array(Tuple(String, String))'), CAST(attributes_string_8, 'Array(Tuple(String, String))'), CAST(attributes_string_9, 'Array(Tuple(String, String))'), CAST(attributes_string_10, 'Array(Tuple(String, String))'), CAST(attributes_string_11, 'Array(Tuple(String, String))'), CAST(attributes_string_12, 'Array(Tuple(String, String))'), CAST(attributes_string_13, 'Array(Tuple(String, String))'), CAST(attributes_string_14, 'Array(Tuple(String, String))'), CAST(attributes_string_15, 'Array(Tuple(String, String))'), CAST(attributes_string_16, 'Array(Tuple(String, String))'), CAST(attributes_string_17, 'Array(Tuple(String, String))'), CAST(attributes_string_18, 'Array(Tuple(String, String))'), CAST(attributes_string_19, 'Array(Tuple(String, String))'), CAST(attributes_string_20, 'Array(Tuple(String, String))'), CAST(attributes_string_21, 'Array(Tuple(String, String))'), CAST(attributes_string_22, 'Array(Tuple(String, String))'), CAST(attributes_string_23, 'Array(Tuple(String, String))'), CAST(attributes_string_24, 'Array(Tuple(String, String))'), CAST(attributes_string_25, 'Array(Tuple(String, String))'), CAST(attributes_string_26, 'Array(Tuple(String, String))'), CAST(attributes_string_27, 'Array(Tuple(String, String))'), CAST(attributes_string_28, 'Array(Tuple(String, String))'), CAST(attributes_string_29, 'Array(Tuple(String, String))'), CAST(attributes_string_30, 'Array(Tuple(String, String))'), CAST(attributes_string_31, 'Array(Tuple(String, String))'), CAST(attributes_string_32, 'Array(Tuple(String, String))'), CAST(attributes_string_33, 'Array(Tuple(String, String))'), CAST(attributes_string_34, 'Array(Tuple(String, String))'), CAST(attributes_string_35, 'Array(Tuple(String, String))'), CAST(attributes_string_36, 'Array(Tuple(String, String))'), CAST(attributes_string_37, 'Array(Tuple(String, String))'), CAST(attributes_string_38, 'Array(Tuple(String, String))'), CAST(attributes_string_39, 'Array(Tuple(String, String))')
) AS attrs
GROUP BY
organization_id,
project_id,
item_type,
attr_key,
attr_value,
timestamp,
retention_days
;
Local op: CREATE TABLE IF NOT EXISTS items_num_attrs_1_local (organization_id UInt64, project_id UInt64, item_type UInt8, attr_key String CODEC (ZSTD(1)), attr_min_value SimpleAggregateFunction(min, Float64), attr_max_value SimpleAggregateFunction(max, Float64), timestamp DateTime CODEC (DoubleDelta, ZSTD(1)), retention_days UInt16, count SimpleAggregateFunction(sum, UInt64)) ENGINE ReplicatedAggregatingMergeTree('/clickhouse/tables/events_analytics_platform/{shard}/default/items_num_attrs_1_local', '{replica}') PRIMARY KEY (organization_id, attr_key) ORDER BY (organization_id, attr_key, item_type, timestamp, project_id, retention_days) PARTITION BY (retention_days, toMonday(timestamp)) TTL timestamp + toIntervalDay(retention_days) SETTINGS index_granularity=8192;
Distributed op: CREATE TABLE IF NOT EXISTS items_num_attrs_1_dist (organization_id UInt64, project_id UInt64, item_type UInt8, attr_key String CODEC (ZSTD(1)), attr_min_value SimpleAggregateFunction(min, Float64), attr_max_value SimpleAggregateFunction(max, Float64), timestamp DateTime CODEC (DoubleDelta, ZSTD(1)), retention_days UInt16, count SimpleAggregateFunction(sum, UInt64)) ENGINE Distributed(`cluster_one_sh`, default, items_num_attrs_1_local);
Local op: CREATE MATERIALIZED VIEW IF NOT EXISTS items_num_attrs_1_mv TO items_num_attrs_1_local (organization_id UInt64, project_id UInt64, item_type UInt8, attr_key String CODEC (ZSTD(1)), attr_min_value SimpleAggregateFunction(min, Float64), attr_max_value SimpleAggregateFunction(max, Float64), timestamp DateTime CODEC (DoubleDelta, ZSTD(1)), retention_days UInt16, count SimpleAggregateFunction(sum, UInt64)) AS
SELECT
organization_id,
project_id,
item_type,
attrs.1 as attr_key,
attrs.2 as attr_min_value,
attrs.2 as attr_max_value,
toStartOfDay(timestamp) AS timestamp,
retention_days,
1 AS count
FROM eap_items_1_local
LEFT ARRAY JOIN
arrayConcat(
CAST(attributes_float_0, 'Array(Tuple(String, Float64))'),CAST(attributes_float_1, 'Array(Tuple(String, Float64))'),CAST(attributes_float_2, 'Array(Tuple(String, Float64))'),CAST(attributes_float_3, 'Array(Tuple(String, Float64))'),CAST(attributes_float_4, 'Array(Tuple(String, Float64))'),CAST(attributes_float_5, 'Array(Tuple(String, Float64))'),CAST(attributes_float_6, 'Array(Tuple(String, Float64))'),CAST(attributes_float_7, 'Array(Tuple(String, Float64))'),CAST(attributes_float_8, 'Array(Tuple(String, Float64))'),CAST(attributes_float_9, 'Array(Tuple(String, Float64))'),CAST(attributes_float_10, 'Array(Tuple(String, Float64))'),CAST(attributes_float_11, 'Array(Tuple(String, Float64))'),CAST(attributes_float_12, 'Array(Tuple(String, Float64))'),CAST(attributes_float_13, 'Array(Tuple(String, Float64))'),CAST(attributes_float_14, 'Array(Tuple(String, Float64))'),CAST(attributes_float_15, 'Array(Tuple(String, Float64))'),CAST(attributes_float_16, 'Array(Tuple(String, Float64))'),CAST(attributes_float_17, 'Array(Tuple(String, Float64))'),CAST(attributes_float_18, 'Array(Tuple(String, Float64))'),CAST(attributes_float_19, 'Array(Tuple(String, Float64))'),CAST(attributes_float_20, 'Array(Tuple(String, Float64))'),CAST(attributes_float_21, 'Array(Tuple(String, Float64))'),CAST(attributes_float_22, 'Array(Tuple(String, Float64))'),CAST(attributes_float_23, 'Array(Tuple(String, Float64))'),CAST(attributes_float_24, 'Array(Tuple(String, Float64))'),CAST(attributes_float_25, 'Array(Tuple(String, Float64))'),CAST(attributes_float_26, 'Array(Tuple(String, Float64))'),CAST(attributes_float_27, 'Array(Tuple(String, Float64))'),CAST(attributes_float_28, 'Array(Tuple(String, Float64))'),CAST(attributes_float_29, 'Array(Tuple(String, Float64))'),CAST(attributes_float_30, 'Array(Tuple(String, Float64))'),CAST(attributes_float_31, 'Array(Tuple(String, Float64))'),CAST(attributes_float_32, 'Array(Tuple(String, Float64))'),CAST(attributes_float_33, 'Array(Tuple(String, Float64))'),CAST(attributes_float_34, 'Array(Tuple(String, Float64))'),CAST(attributes_float_35, 'Array(Tuple(String, Float64))'),CAST(attributes_float_36, 'Array(Tuple(String, Float64))'),CAST(attributes_float_37, 'Array(Tuple(String, Float64))'),CAST(attributes_float_38, 'Array(Tuple(String, Float64))'),CAST(attributes_float_39, 'Array(Tuple(String, Float64))')
) AS attrs
GROUP BY
organization_id,
project_id,
item_type,
attrs.1,
attrs.2,
timestamp,
retention_days
;
-- end forward migration events_analytics_platform : 0029_items_attribute_table_v1
-- backward migration events_analytics_platform : 0029_items_attribute_table_v1
Local op: DROP TABLE IF EXISTS items_str_attrs_1_mv;
Local op: DROP TABLE IF EXISTS items_str_attrs_1_local;
Distributed op: DROP TABLE IF EXISTS items_str_attrs_1_dist;
Local op: DROP TABLE IF EXISTS items_num_attrs_1_mv;
Local op: DROP TABLE IF EXISTS items_num_attrs_1_local;
Distributed op: DROP TABLE IF EXISTS items_num_attrs_1_dist;
-- end backward migration events_analytics_platform : 0029_items_attribute_table_v1 |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
kylemumma
commented
Feb 21, 2025
| str_columns: Sequence[Column[Modifiers]] = [ | ||
| Column("organization_id", UInt(64)), | ||
| Column("project_id", UInt(64)), | ||
| Column("item_type", UInt(8)), |
There was a problem hiding this comment.
new column for item_type
kylemumma
commented
Feb 21, 2025
| engine=table_engines.AggregatingMergeTree( | ||
| storage_set=self.storage_set_key, | ||
| primary_key="(organization_id, attr_key)", | ||
| order_by="(organization_id, attr_key, item_type, attr_value, project_id, timestamp, retention_days)", |
There was a problem hiding this comment.
add item_type to sort key.
is this the right place in the sort key or should it be changed?
should it be added to primary_key?
kylemumma
commented
Feb 21, 2025
| LEFT ARRAY JOIN | ||
| arrayConcat( | ||
| {", ".join(f"CAST(attributes_string_{n}, 'Array(Tuple(String, String))')" for n in range(ITEM_ATTRIBUTE_BUCKETS))} | ||
| ) AS attrs |
There was a problem hiding this comment.
at this part the old mvs also had
array(
tuple('sentry.service', `service`),
tuple('sentry.segment_name', `segment_name`),
tuple('sentry.name', `name`)
)
i removed that since those columns dont exist in eap_items
kylemumma
commented
Feb 21, 2025
| LEFT ARRAY JOIN | ||
| arrayConcat( | ||
| {",".join(f"CAST(attributes_float_{n}, 'Array(Tuple(String, Float64))')" for n in range(ITEM_ATTRIBUTE_BUCKETS))} | ||
| ) AS attrs |
There was a problem hiding this comment.
at this part the old mvs also had
array(
tuple('sentry.duration_ms', duration_micro / 1000)
)
i removed that since the column doesnt exist anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the purpose of this PR is to recreate the existing
spans_num_attrs_3_mvandspans_str_attrs_3_mvand the underlyingspans_str_attrs_3_localandspans_num_attrs_3_localtables so they read fromeap_items_1_localinstead ofeap_spans_2_localit addresses this ticket https://github.com/getsentry/eap-planning/issues/194
changes
items_str_attrs_1anditems_num_attrs_1reading fromeap_itemsvia migration