Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHSA-4x9r-j582-cgr8.json fixed versions #5277

Open
wants to merge 2 commits into
base: alowayed/advisory-improvement-5277
Choose a base branch
from

Conversation

alowayed
Copy link

@alowayed alowayed commented Feb 14, 2025

Update fixed versions for Maven and PyPI ecosystems.

Change last_affected to fixed to more closely match the recommendations in: https://lists.apache.org/thread/p847l3kopoo5bjtmxrcwk21xp6tjxqlc

Upgrade to supported Apache Spark maintenance release 3.1.3, 3.2.2, or 3.3.0 or later

This could be replaced with:

{
  {"introduced": "0"},
  {"last_affected": "3.0.3"}
},
{
  {"introduced": "3.1.0"},
  {"fixed": "3.1.3"}
},
{
  {"introduced": "3.2.0"},
  {"fixed": "3.2.2"}
}

But given there is no version between 3.0.3 and 3.1.0 this seems unnecessary and potentially confusing.

This change follows the OSV format recommendations to use fixed instead of last_affected: https://ossf.github.io/osv-schema/#requirements

Update last affected to fixed.
@github-actions github-actions bot changed the base branch from main to alowayed/advisory-improvement-5277 February 14, 2025 17:06
@JonathanLEvans
Copy link

Hi @alowayed, thank you for your interest in the GitHub Advisory Database. The way I read

This affects Apache Spark versions 3.0.3 and earlier, versions 3.1.1 to 3.1.2, and versions 3.2.0 to 3.2.1.

from https://lists.apache.org/thread/p847l3kopoo5bjtmxrcwk21xp6tjxqlc, is that 3.1.0 is not affected. Is there somewhere that states that 3.1.0 is affected?

@alowayed
Copy link
Author

I was worried that was a mistake on Apache's part. It seems odd to me that version 3.1.0 would be safe while versions 3.1.1 and 3.1.2 are vulnerable. But it's best to stick with exactly what Apache reported. Updated the PR.

@JonathanLEvans
Copy link

Hi @alowayed, per https://www.openwall.com/lists/oss-security/2023/05/02/1, 3.1.3 is also affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants