Feature: Ephemeral action runners #33570
Draft
+198
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
ChristopherHX
commented
Feb 14, 2025
| if runner.Ephemeral { | ||
| var task actions_model.ActionTask | ||
| has, err := db.GetEngine(ctx).Where("runner_id = ?", runner.ID).Get(&task) | ||
| if err == nil && has { |
There was a problem hiding this comment.
We should abort here on error, otherwise someone could bypass this code while the database is overloaded
This was referenced Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32461
Draft as long (https://gitea.com/gitea/actions-proto-def/pulls/14) and this message is in the Original Post
Potential Problem
Concurrently requesting jobs from an act_runner (which a regular act_runner would never do)
However it could fail as well and return "no job available" like described in
https://github.com/go-gitea/gitea/issues/33492Another Problem
#33570 (comment)