-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reverse proxy providing email #5554
Support reverse proxy providing email #5554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to example app.ini the conf value as well
I knew there was somewhere else. The other values aren't in the example app.ini - I guess I should add those too |
This PR implements go-gitea#2347
a5a3439
to
3636c9b
Compare
OK that was weird - so I searched again today and the original values pop up in the app.ini.sample ... I'm not sure what happened there! |
@techknowlogick : I've added the appropriate lines to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeripath Look's great!
Codecov Report
@@ Coverage Diff @@
## master #5554 +/- ##
==========================================
- Coverage 37.55% 37.54% -0.01%
==========================================
Files 321 321
Lines 47172 47181 +9
==========================================
- Hits 17714 17713 -1
- Misses 26916 26924 +8
- Partials 2542 2544 +2
Continue to review full report at Codecov.
|
This PR implements #2347 by allowing the reverse proxy to set the email address on auto-register.
The current implementation does not allow for changing the email address using the reverse proxy - perhaps it should?