CMake: Fix unknown architecture and simplify OSX_ARCHITECTURES #1708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was brought to my attention that @Naros was getting builds with the architecture name tag set to
unknown
This is cosmetic and doesnt effect the build, but did expose an underlying problem with how I was treating the
CMAKE_SYSTEM_PROCESSOR
flag, and how I was generating theOUTPUT_NAME
It also made me re-examine how I was treating the
OSX_ARCHITECTURES
, in light of the recentMSVC_RUNTIME_LIBRARIES
#1701 discussionChanges:
GODOT_ARCH
option, it's managed by the toolchain files, or build vars.godot_arch_map
togodot_arch_name
to better describe its usegodot_arch_name
internal lists${CMAKE_SYSTEM_PROCESSOR}
when architecture is unknown instead ofunknown
OSX_ARCHITECTURES
, anduniversal
and provide links to documentation on how to useOSX_ARCHITEXTURES
in thecmake/macos.cmake
headerThis simplifies the case for MacOS, iOS, and makes the resulting naming more predictable