Fix PopupMenu clickable area with shadows #103155
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giganzo
force-pushed
the
popup-menu-shadow
branch
2 times, most recently
from
2c07ed9 to
0d30de1
Compare
KoBeWi
reviewed
Feb 22, 2025
KoBeWi
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #103149
Not sure if these issues are already being tracked but this change makes them more obvious.
Scrollbar was not being ignored when pressed. And if you set a panel margin right this is also not ignored.
This PR should also fix these issues.
No shadow
Before:
Screencast_20250219_160121.webm
After:
Screencast_20250219_160250.webm
With shadow
Before:
Screencast_20250219_160400.webm
After:
Screencast_20250219_160515.webm