Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit changed signal on SpriteFrames for animation changes. #103189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hworld
Copy link

@hworld hworld commented Feb 22, 2025

Currently only the frame-related updates emit the changed signal. This changes it to also emit for changes in the animations, such as adding an animation, renaming, setting loop, etc.

Currently only the frame-related updates emit the changed signal. This changes it to also emit for changes in the animations, such as adding an animation, renaming, setting loop, etc.
@Chaosus
Copy link
Member

Chaosus commented Feb 23, 2025

Not sure if this is safe to introduce to 4.x - users may wonder why that signal start to emitted for simple operations (which may cause unwanted effects for the existed projects).

Also - CI failed, you need to fix it (use clang-format next time to prevent this from happen) and squash the commits (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#modifying-a-pull-request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants